Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

Felipe Balbi
2013-07-29T11:09:22Z

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi,

On Mon, Jul 29, 2013 at 04:34:41PM +0530, Sourav Poddar wrote:
> >>>>+ irq = platform_get_irq(pdev, 0);
> >>>>+ if (irq< 0) {
> >>>>+ dev_err(&pdev->dev, "no irq resource?\n");
> >>>>+ return irq;
> >>>>+ }
> >>>>+
> >>>>+ spin_lock_init(&qspi->lock);
> >>>>+
> >>>>+ qspi->base = devm_ioremap_resource(&pdev->dev, r);
> >>>>+ if (IS_ERR(qspi->base)) {
> >>>>+ ret = PTR_ERR(qspi->base);
> >>>>+ goto free_master;
> >>>>+ }
> >>>>+
> >>>>+ ret = devm_request_threaded_irq(&pdev->dev, irq, ti_qspi_isr,
> >>>>+ ti_qspi_threaded_isr, IRQF_NO_SUSPEND | IRQF_ONESHOT,
> >>>why do you need IRQF_NO_SUSPEND ?
> >>>
> >>I should get away with this.
> >why ? Do you need or do you *not* need it ? And in either case, why ?
> >
> I was thinking, this will keep the irqs up even when we are
> hitting suspend, we will not be prepared to handle it. ?

won't be prepared in what way ?

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]