Re: [RFC/PATCH 2/2] driver: spi: Add quad spi read support

Felipe Balbi
2013-07-29T09:33:19Z

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

On Mon, Jul 29, 2013 at 12:52:30PM +0530, Sourav Poddar wrote:
> Since, qspi controller uses quad read.
>
> Configuring the command register, if the transfer of data needs
> dual or quad lines.
>
> This patch has been done on top of the following patch[1], which is just the
> basic idea of adding dual/quad support in spi framework.
> $subject patch will undergo changes with the ongoing discussion in the
> community.
>
> This patch is posted to demonstrate how patch 1 of the series will support
> quad read.
>
> [1]: http://comments.gmane.org/gmane.linux.kernel.spi.devel/14047
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> drivers/spi/spi-ti-qspi.c | 16 ++++++++++++++--
> 1 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 51fe95f..8a32b1c 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -86,6 +86,7 @@ struct ti_qspi {
> #define QSPI_3_PIN (1 << 18)
> #define QSPI_RD_SNGL (1 << 16)
> #define QSPI_WR_SNGL (2 << 16)
> +#define QSPI_RD_DUAL (3 << 16)
> #define QSPI_RD_QUAD (7 << 16)

so RD_QUAD is defined in previous patch but not RD_DUAL ? What gives ?

IMHO, just merge this patch with previous and make the entire driver
depend on the other patch.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]