From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/5] pdev: Fix platform device resource linking Date: Tue, 6 Aug 2013 11:19:14 +0100 Message-ID: <20130806101914.GH23053@n2100.arm.linux.org.uk> References: <1375775624-12250-1-git-send-email-panto@antoniou-consulting.com> <1375775624-12250-2-git-send-email-panto@antoniou-consulting.com> <20130806093601.GB27889@kroah.com> <311C42C3-6544-4058-ABE9-F9FAE72DD5CA@antoniou-consulting.com> <20130806101527.GB29283@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40584 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754884Ab3HFKTg (ORCPT ); Tue, 6 Aug 2013 06:19:36 -0400 Content-Disposition: inline In-Reply-To: <20130806101527.GB29283@kroah.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Greg Kroah-Hartman Cc: Pantelis Antoniou , Tony Lindgren , =?iso-8859-1?Q?Beno=EEt?= Coussno , Paul Walmsley , Sourav Poddar , Russ Dill , Felipe Balbi , Koen Kooi , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Aug 06, 2013 at 06:15:27PM +0800, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2013 at 12:45:42PM +0300, Pantelis Antoniou wrote: > > What would it take to move all this into driver core? > > What specifically would you move into there? A variable to hold the streaming dma_mask, so that its in struct device rather than having to be separate. Yes, we can keep the pointer in there too, because that appears to convey meaning in the kernel today - whether the device can do DMA or not. A NULL dma_mask pointer already means it can't and dma_set_mask() always fails. A non-NULL dma_mask pointer means the driver can use dma_set_mask() to set an appropriate mask.