* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-07 11:06 [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property Lars Poeschel
@ 2013-08-07 11:27 ` Javier Martinez Canillas
2013-08-07 14:53 ` Mark Rutland
2013-08-21 7:50 ` Tony Lindgren
2 siblings, 0 replies; 9+ messages in thread
From: Javier Martinez Canillas @ 2013-08-07 11:27 UTC (permalink / raw)
To: Lars Poeschel
Cc: poeschel, b-cousson, tony, rob.herring, pawel.moll, mark.rutland,
swarren, ian.campbell, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On Wed, Aug 7, 2013 at 1:06 PM, Lars Poeschel <larsi@wh2.tu-dresden.de> wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
>
Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-07 11:06 [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property Lars Poeschel
2013-08-07 11:27 ` Javier Martinez Canillas
@ 2013-08-07 14:53 ` Mark Rutland
2013-08-07 15:11 ` Lars Poeschel
2013-08-21 7:50 ` Tony Lindgren
2 siblings, 1 reply; 9+ messages in thread
From: Mark Rutland @ 2013-08-07 14:53 UTC (permalink / raw)
To: Lars Poeschel
Cc: poeschel@lemonage.de, b-cousson@ti.com, tony@atomide.com,
rob.herring@calxeda.com, Pawel Moll, swarren@wwwdotorg.org,
ian.campbell@citrix.com, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
I take it there are no device nodes for which any of these nodes are an
interrupt parent (which would need to be updated)?
If so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-07 14:53 ` Mark Rutland
@ 2013-08-07 15:11 ` Lars Poeschel
2013-08-13 13:25 ` Benoit Cousson
0 siblings, 1 reply; 9+ messages in thread
From: Lars Poeschel @ 2013-08-07 15:11 UTC (permalink / raw)
To: Mark Rutland
Cc: Lars Poeschel, b-cousson@ti.com, tony@atomide.com,
rob.herring@calxeda.com, Pawel Moll, swarren@wwwdotorg.org,
ian.campbell@citrix.com, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wednesday 07 August 2013 at 16:53:09, Mark Rutland wrote:
> On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> > From: Lars Poeschel <poeschel@lemonage.de>
> >
> > Following commit ff5c9059 and therefore other omap platforms using
> > the gpio-omap driver correct the #interrupt-cells property on am33xx
> > too. The omap gpio binding documentaion also states that
> > the #interrupt-cells property should be 2.
>
> I take it there are no device nodes for which any of these nodes are an
> interrupt parent (which would need to be updated)?
As far as I know: No.
Lars
> If so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks,
> Mark.
>
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > ---
> >
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..033c5dd 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -102,7 +102,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x44e07000 0x1000>;
> > interrupts = <96>;
> >
> > };
> >
> > @@ -113,7 +113,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x4804c000 0x1000>;
> > interrupts = <98>;
> >
> > };
> >
> > @@ -124,7 +124,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ac000 0x1000>;
> > interrupts = <32>;
> >
> > };
> >
> > @@ -135,7 +135,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ae000 0x1000>;
> > interrupts = <62>;
> >
> > };
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-07 15:11 ` Lars Poeschel
@ 2013-08-13 13:25 ` Benoit Cousson
0 siblings, 0 replies; 9+ messages in thread
From: Benoit Cousson @ 2013-08-13 13:25 UTC (permalink / raw)
To: Lars Poeschel
Cc: Mark Rutland, Lars Poeschel, b-cousson@ti.com, tony@atomide.com,
rob.herring@calxeda.com, Pawel Moll, swarren@wwwdotorg.org,
ian.campbell@citrix.com, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi lars,
On 07/08/2013 17:11, Lars Poeschel wrote:
> On Wednesday 07 August 2013 at 16:53:09, Mark Rutland wrote:
>> On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
>>> From: Lars Poeschel <poeschel@lemonage.de>
>>>
>>> Following commit ff5c9059 and therefore other omap platforms using
>>> the gpio-omap driver correct the #interrupt-cells property on am33xx
>>> too. The omap gpio binding documentaion also states that
>>> the #interrupt-cells property should be 2.
>>
>> I take it there are no device nodes for which any of these nodes are an
>> interrupt parent (which would need to be updated)?
>
> As far as I know: No.
>
> Lars
>
>> If so:
>>
>> Acked-by: Mark Rutland <mark.rutland@arm.com>
>>
>> Thanks,
>> Mark.
>>
>>> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Thank, applied with Mark and Javier A-By / R-By.
Thanks,
Benoit
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-07 11:06 [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property Lars Poeschel
2013-08-07 11:27 ` Javier Martinez Canillas
2013-08-07 14:53 ` Mark Rutland
@ 2013-08-21 7:50 ` Tony Lindgren
2013-08-21 7:57 ` Lars Poeschel
2 siblings, 1 reply; 9+ messages in thread
From: Tony Lindgren @ 2013-08-21 7:50 UTC (permalink / raw)
To: Benoit Cousson, Lars Poeschel
Cc: poeschel, rob.herring, pawel.moll, mark.rutland, swarren,
ian.campbell, linux, linux-omap, devicetree, linux-arm-kernel,
linux-kernel
Benoit,
Care to take a look at this too?
* Lars Poeschel <larsi@wh2.tu-dresden.de> [130807 04:14]:
> From: Lars Poeschel <poeschel@lemonage.de>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-21 7:50 ` Tony Lindgren
@ 2013-08-21 7:57 ` Lars Poeschel
2013-08-21 7:59 ` Tony Lindgren
0 siblings, 1 reply; 9+ messages in thread
From: Lars Poeschel @ 2013-08-21 7:57 UTC (permalink / raw)
To: Tony Lindgren
Cc: Benoit Cousson, Lars Poeschel, rob.herring, pawel.moll,
mark.rutland, swarren, ian.campbell, linux, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
Hi Tony!
On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
> Benoit,
>
> Care to take a look at this too?
Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
Canillas Reviewed-by.
Regards,
Lars
> * Lars Poeschel <larsi@wh2.tu-dresden.de> [130807 04:14]:
> > From: Lars Poeschel <poeschel@lemonage.de>
> >
> > Following commit ff5c9059 and therefore other omap platforms using
> > the gpio-omap driver correct the #interrupt-cells property on am33xx
> > too. The omap gpio binding documentaion also states that
> > the #interrupt-cells property should be 2.
> >
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > ---
> >
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..033c5dd 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -102,7 +102,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x44e07000 0x1000>;
> > interrupts = <96>;
> >
> > };
> >
> > @@ -113,7 +113,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x4804c000 0x1000>;
> > interrupts = <98>;
> >
> > };
> >
> > @@ -124,7 +124,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ac000 0x1000>;
> > interrupts = <32>;
> >
> > };
> >
> > @@ -135,7 +135,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ae000 0x1000>;
> > interrupts = <62>;
> >
> > };
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-21 7:57 ` Lars Poeschel
@ 2013-08-21 7:59 ` Tony Lindgren
2013-08-21 9:25 ` Benoit Cousson
0 siblings, 1 reply; 9+ messages in thread
From: Tony Lindgren @ 2013-08-21 7:59 UTC (permalink / raw)
To: Lars Poeschel
Cc: Benoit Cousson, Lars Poeschel, rob.herring, pawel.moll,
mark.rutland, swarren, ian.campbell, linux, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
* Lars Poeschel <poeschel@lemonage.de> [130821 01:04]:
> Hi Tony!
>
> On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
> > Benoit,
> >
> > Care to take a look at this too?
>
> Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
> Canillas Reviewed-by.
OK thanks for the update, I'm just trying to follow-up and clear
my inbox a bit.
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
2013-08-21 7:59 ` Tony Lindgren
@ 2013-08-21 9:25 ` Benoit Cousson
0 siblings, 0 replies; 9+ messages in thread
From: Benoit Cousson @ 2013-08-21 9:25 UTC (permalink / raw)
To: Tony Lindgren
Cc: Lars Poeschel, Lars Poeschel, rob.herring, pawel.moll,
mark.rutland, swarren, ian.campbell, linux, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
Hi Tony,
On 21/08/2013 09:59, Tony Lindgren wrote:
> * Lars Poeschel <poeschel@lemonage.de> [130821 01:04]:
>> Hi Tony!
>>
>> On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
>>> Benoit,
>>>
>>> Care to take a look at this too?
>>
>> Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
>> Canillas Reviewed-by.
>
> OK thanks for the update, I'm just trying to follow-up and clear
> my inbox a bit.
I've just checked, because I thought I missed it, and this is indeed in
my pull request I sent you yesterday.
Thanks,
Benoit
^ permalink raw reply [flat|nested] 9+ messages in thread