From: Tony Lindgren <tony@atomide.com>
To: ujhelyi.m@gmail.com
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] am33xx-restart: trigger warm reset on omap2+ boards
Date: Wed, 21 Aug 2013 01:02:01 -0700 [thread overview]
Message-ID: <20130821080201.GB7656@atomide.com> (raw)
In-Reply-To: <1375696944-13380-1-git-send-email-ujhelyi.m@gmail.com>
* ujhelyi.m@gmail.com <ujhelyi.m@gmail.com> [130805 03:09]:
> From: Matus Ujhelyi <ujhelyi.m@gmail.com>
>
> Currently the cold reset was triggered. It happened due to oposite offsets
> of cold/warm flags in PRM_RSTST and PRM_RSTCTRL registers.
Thanks applying into omap-for-v3.12/fixes-non-critical.
Tony
> Signed-off-by: Matus Ujhelyi <ujhelyi.m@gmail.com>
> ---
> arch/arm/mach-omap2/am33xx-restart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/am33xx-restart.c b/arch/arm/mach-omap2/am33xx-restart.c
> index 1eae962..c88d8df7 100644
> --- a/arch/arm/mach-omap2/am33xx-restart.c
> +++ b/arch/arm/mach-omap2/am33xx-restart.c
> @@ -24,8 +24,8 @@ void am33xx_restart(enum reboot_mode mode, const char *cmd)
> {
> /* TODO: Handle mode and cmd if necessary */
>
> - am33xx_prm_rmw_reg_bits(AM33XX_GLOBAL_WARM_SW_RST_MASK,
> - AM33XX_GLOBAL_WARM_SW_RST_MASK,
> + am33xx_prm_rmw_reg_bits(AM33XX_RST_GLOBAL_WARM_SW_MASK,
> + AM33XX_RST_GLOBAL_WARM_SW_MASK,
> AM33XX_PRM_DEVICE_MOD,
> AM33XX_PRM_RSTCTRL_OFFSET);
>
> --
> 1.7.9.5
>
prev parent reply other threads:[~2013-08-21 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 10:02 [PATCH] am33xx-restart: trigger warm reset on omap2+ boards ujhelyi.m
2013-08-21 8:02 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821080201.GB7656@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).