From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start' Date: Thu, 22 Aug 2013 00:57:32 -0700 Message-ID: <20130822075731.GT7656@atomide.com> References: <521479B4.8030604@asianux.com> <20130822071402.GQ7656@atomide.com> <5215C12D.5020807@asianux.com> <5215C209.3080606@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:63788 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443Ab3HVH5h (ORCPT ); Thu, 22 Aug 2013 03:57:37 -0400 Content-Disposition: inline In-Reply-To: <5215C209.3080606@asianux.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Chen Gang Cc: Kevin Hilman , Russell King - ARM Linux , linux-omap@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" * Chen Gang [130822 00:55]: > 'gpmc_irq_start' is mostly used as 'int', and for a variable, do not > suggest to only use 'unsigned' as its type, so use 'int' instead of > 'unsigned' for variable 'gpmc_irq_start'. > > Also it will fix the related issue (dummy the real world failure): > > arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > Thanks applying into omap-for-v3.12/fixes-non-critical. Tony > Signed-off-by: Chen Gang > --- > arch/arm/mach-omap2/gpmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c > index f3fdd6a..9f4795a 100644 > --- a/arch/arm/mach-omap2/gpmc.c > +++ b/arch/arm/mach-omap2/gpmc.c > @@ -149,7 +149,7 @@ struct omap3_gpmc_regs { > > static struct gpmc_client_irq gpmc_client_irq[GPMC_NR_IRQ]; > static struct irq_chip gpmc_irq_chip; > -static unsigned gpmc_irq_start; > +static int gpmc_irq_start; > > static struct resource gpmc_mem_root; > static struct resource gpmc_cs_mem[GPMC_CS_NUM]; > -- > 1.7.7.6