From: Dan Carpenter <dan.carpenter@oracle.com>
To: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org
Subject: re: OMAPDSS: remove dispc's dependency to VENC/HDMI
Date: Tue, 27 Aug 2013 04:20:16 +0300 [thread overview]
Message-ID: <20130827012016.GE17061@elgon.mountain> (raw)
Hello Tomi Valkeinen,
This is a semi-automatic email about new static checker warnings.
The patch 5391e87d1259: "OMAPDSS: remove dispc's dependency to
VENC/HDMI" from May 16, 2013, leads to the following Smatch complaint:
drivers/video/omap2/dss/hdmi.c:672 omapdss_hdmi_display_set_timing()
error: we previously assumed 't' could be null (see line 669)
drivers/video/omap2/dss/hdmi.c
668 t = hdmi_get_timings();
669 if (t != NULL)
^^^^^^^^^
Existing check.
670 hdmi.ip_data.cfg = *t;
671
672 dispc_set_tv_pclk(t->timings.pixel_clock * 1000);
^^^^^^^^^^^^^^^^^^^^^^
Patch added a dereference.
673
674 mutex_unlock(&hdmi.lock);
regards,
dan carpenter
next reply other threads:[~2013-08-27 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 1:20 Dan Carpenter [this message]
2013-08-27 11:16 ` OMAPDSS: remove dispc's dependency to VENC/HDMI Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827012016.GE17061@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox