From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Date: Thu, 5 Sep 2013 16:16:39 -0400 Message-ID: <20130905201637.GB10973@ohporter.com> References: <871u70bd95.fsf@dell.be.48ers.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <871u70bd95.fsf@dell.be.48ers.dk> Sender: netdev-owner@vger.kernel.org To: Peter Korsgaard Cc: Mark Jackson , tony@atomide.com, Mugunthan V N , linux-omap@vger.kernel.org, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, hvaibhav@ti.com, richardcochran@gmail.com, Olof Johansson , Kevin Hilman , michal.bachraty@gmail.com, michal.bachraty@streamunlimited.com List-Id: linux-omap@vger.kernel.org On Mon, Jul 15, 2013 at 07:31:18AM +0200, Peter Korsgaard wrote: > >>>>> "Mark" == Mark Jackson writes: > > Hi, > > Mark> On 08/07/13 13:42, Mark Jackson wrote: > >> On 18/01/13 05:14, Mugunthan V N wrote: > >>> On 1/18/2013 3:48 AM, Peter Korsgaard wrote: > >>>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old > >>>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot > >>>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the > >>>> CPSW slaves, causing the driver to use a random hwaddr, which is some times > >>>> troublesome. > >>>> > >>>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes > >>>> more sense to default to these rather than random ones. Add a fixup step > >>>> which adds mac-address dt properties using the efuse addresses if the DTB > >>>> didn't contain valid ones. > >>>> > >>>> Signed-off-by: Peter Korsgaard > >>> > >>> This implementation looks fine. > >>> Acked-by: Mugunthan V N > >> > >> Tested-by: Mark Jackson > > Mark> Is this ever going to be put into the mainline code ? > > Good question. Tony, could you please pick this up? It has been pending > since January and has a number of acks. > > Do you want me to resend? Also working nicely here on 3.11. Tested-by: Matt Porter Kevin or Olof: can you apply? Seems to be continuing no response after Ack back in January. -Matt