From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Kevin Hilman <khilman@linaro.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Anil Kumar <anilk4.v@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Tony Lindgren <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH] arm: Fix build error with context tracking calls
Date: Sat, 14 Sep 2013 15:32:13 +0100 [thread overview]
Message-ID: <20130914143213.GN25647@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130913170331.GA8453@somewhere>
On Fri, Sep 13, 2013 at 07:03:34PM +0200, Frederic Weisbecker wrote:
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index 247091b..859c8df 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -51,6 +51,15 @@ void context_tracking_user_enter(void)
> unsigned long flags;
>
> /*
> + * Repeat the user_enter() check here because some archs may be calling
> + * this from asm and if no CPU needs context tracking, they shouldn't
> + * go further. We can remove that check here once these archs support the static key
> + * check.
The only (minor) comment on this is that the above would fail checkpatch,
but that's not a good enough reason to respin it if you've already applied
it IMHO.
next prev parent reply other threads:[~2013-09-15 13:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 6:04 Build error in torvalds kernel 3.11 for omap2plus Anil Kumar
2013-09-08 9:02 ` Russell King - ARM Linux
2013-09-08 17:16 ` Guenter Roeck
2013-09-09 10:51 ` Russell King - ARM Linux
2013-09-09 12:00 ` Guenter Roeck
2013-09-09 14:24 ` Nicolas Pitre
2013-09-09 16:03 ` Guenter Roeck
2013-09-09 20:31 ` Russell King - ARM Linux
2013-09-09 21:02 ` Guenter Roeck
2013-09-09 21:16 ` Nicolas Pitre
2013-09-10 15:07 ` Kevin Hilman
2013-09-10 15:09 ` Frederic Weisbecker
2013-09-13 17:03 ` [PATCH] arm: Fix build error with context tracking calls Frederic Weisbecker
2013-09-13 22:50 ` Kevin Hilman
2013-09-14 14:19 ` Frederic Weisbecker
2013-09-16 17:11 ` Kevin Hilman
2013-09-14 14:32 ` Russell King - ARM Linux [this message]
2013-09-22 16:59 ` Frederic Weisbecker
2013-09-25 17:38 ` Kevin Hilman
2013-09-27 13:30 ` Frederic Weisbecker
2013-09-09 10:55 ` Build error in torvalds kernel 3.11 for omap2plus Anil Kumar
2013-09-09 11:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914143213.GN25647@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=anilk4.v@gmail.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fweisbec@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nicolas.pitre@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).