From: Tony Lindgren <tony@atomide.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>, "nm@ti.com" <nm@ti.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1
Date: Tue, 17 Sep 2013 08:43:31 -0700 [thread overview]
Message-ID: <20130917154331.GA9994@atomide.com> (raw)
In-Reply-To: <20130916171023.GA17477@localhost.localdomain>
* Dave Martin <Dave.Martin@arm.com> [130916 10:18]:
> On Sat, Sep 14, 2013 at 10:37:12AM +0100, Pali Rohár wrote:
> > On Sunday 08 September 2013 09:43:29 Pali Rohár wrote:
> > > + */
> > > +ENTRY(omap_smc3)
> > > + stmfd sp!, {r4-r11, lr}
> > > + mov r12, r0 @ Copy the secure service ID
> > > + mov r6, #0xff @ Indicate new Task call
> > > + dsb @ Memory Barrier (not sure if needed, copied from
> > > omap_smc2) + smc #1 @ Call PPA service
> > > + ldmfd sp!, {r4-r11, pc}
> > > +ENDPROC(omap_smc3)
> > > +
> > > ENTRY(omap_modify_auxcoreboot0)
> > > stmfd sp!, {r1-r12, lr}
> > > ldr r12, =0x104
> >
> > Dave, it is ok now?
>
> Yes, that's sufficient to warn people to stop and think (at least, if
> someone copy-pastes it, they will likely highlight the possible error by
> copy-pasting the comment too). Thanks.
>
> Acked-by: Dave Martin <Dave.Martin@arm.com>
Have you guys checked how this works with the recently posted
"[PATCH v6 0/5] ARM: support for Trusted Foundations secure monitor"
series?
Regards,
Tony
next prev parent reply other threads:[~2013-09-17 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 17:10 [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Dave Martin
2013-09-17 15:43 ` Tony Lindgren [this message]
2013-09-17 15:53 ` Pali Rohár
2013-09-17 23:17 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 12:43 [PATCH v3 " Dave Martin
2013-09-08 7:43 ` [PATCH v4 " Pali Rohár
2013-09-14 9:37 ` Pali Rohár
2013-10-08 7:13 ` Ben Dooks
2013-10-08 8:09 ` Russell King - ARM Linux
2013-10-08 19:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917154331.GA9994@atomide.com \
--to=tony@atomide.com \
--cc=Dave.Martin@arm.com \
--cc=aaro.koskinen@iki.fi \
--cc=freemangordon@abv.bg \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=pdeschrijver@nvidia.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).