linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"'Rafael J. Wysocki'" <rafael.j.wysocki@intel.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()
Date: Tue, 17 Sep 2013 16:44:25 -0700	[thread overview]
Message-ID: <20130917234424.GP9994@atomide.com> (raw)
In-Reply-To: <52178FAD.7040402@ti.com>

* Suman Anna <s-anna@ti.com> [130823 09:50]:
> + OMAP mailing list
> 
> Tony,
> Can you pick up this minor cleanup patch?
> 
> regards
> Suman
> 
> On 08/21/2013 09:10 PM, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> > 
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> 
> Acked-by: Suman Anna <s-anna@ti.com>

OK applying into omap-for-v3.12/fixes thanks.

Regards,

Tony
 
> > ---
> >  drivers/mailbox/mailbox-omap2.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c
> > index eba380d..42d2b89 100644
> > --- a/drivers/mailbox/mailbox-omap2.c
> > +++ b/drivers/mailbox/mailbox-omap2.c
> > @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev)
> >  	kfree(privblk);
> >  	kfree(mboxblk);
> >  	kfree(list);
> > -	platform_set_drvdata(pdev, NULL);
> >  
> >  	return 0;
> >  }
> > 
> 

      reply	other threads:[~2013-09-17 23:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <002201ce9edc$cdc3fb90$694bf2b0$%han@samsung.com>
2013-08-23 16:37 ` [PATCH] mailbox: remove unnecessary platform_set_drvdata() Suman Anna
2013-09-17 23:44   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917234424.GP9994@atomide.com \
    --to=tony@atomide.com \
    --cc=akpm@linux-foundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).