* Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata() [not found] <002201ce9edc$cdc3fb90$694bf2b0$%han@samsung.com> @ 2013-08-23 16:37 ` Suman Anna 2013-09-17 23:44 ` Tony Lindgren 0 siblings, 1 reply; 2+ messages in thread From: Suman Anna @ 2013-08-23 16:37 UTC (permalink / raw) To: Tony Lindgren Cc: Jingoo Han, Andrew Morton, linux-kernel, 'Rafael J. Wysocki', linux-omap@vger.kernel.org + OMAP mailing list Tony, Can you pick up this minor cleanup patch? regards Suman On 08/21/2013 09:10 PM, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Suman Anna <s-anna@ti.com> > --- > drivers/mailbox/mailbox-omap2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c > index eba380d..42d2b89 100644 > --- a/drivers/mailbox/mailbox-omap2.c > +++ b/drivers/mailbox/mailbox-omap2.c > @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev) > kfree(privblk); > kfree(mboxblk); > kfree(list); > - platform_set_drvdata(pdev, NULL); > > return 0; > } > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata() 2013-08-23 16:37 ` [PATCH] mailbox: remove unnecessary platform_set_drvdata() Suman Anna @ 2013-09-17 23:44 ` Tony Lindgren 0 siblings, 0 replies; 2+ messages in thread From: Tony Lindgren @ 2013-09-17 23:44 UTC (permalink / raw) To: Suman Anna Cc: Jingoo Han, Andrew Morton, linux-kernel, 'Rafael J. Wysocki', linux-omap@vger.kernel.org * Suman Anna <s-anna@ti.com> [130823 09:50]: > + OMAP mailing list > > Tony, > Can you pick up this minor cleanup patch? > > regards > Suman > > On 08/21/2013 09:10 PM, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > Acked-by: Suman Anna <s-anna@ti.com> OK applying into omap-for-v3.12/fixes thanks. Regards, Tony > > --- > > drivers/mailbox/mailbox-omap2.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c > > index eba380d..42d2b89 100644 > > --- a/drivers/mailbox/mailbox-omap2.c > > +++ b/drivers/mailbox/mailbox-omap2.c > > @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev) > > kfree(privblk); > > kfree(mboxblk); > > kfree(list); > > - platform_set_drvdata(pdev, NULL); > > > > return 0; > > } > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-17 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <002201ce9edc$cdc3fb90$694bf2b0$%han@samsung.com>
2013-08-23 16:37 ` [PATCH] mailbox: remove unnecessary platform_set_drvdata() Suman Anna
2013-09-17 23:44 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).