linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rob Landley <rob@landley.net>
Cc: "Måns Rullgård" <mans@mansr.com>, "Andrew Morton" <akpm@osdl.org>,
	"Trivial patch monkey" <trivial@kernel.org>,
	"Catalin Marinas" <Catalin.Marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: new binutils needed for arm in 3.12-rc1
Date: Tue, 24 Sep 2013 22:48:00 +0100	[thread overview]
Message-ID: <20130924214800.GV25647@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1380057828.1974.73@driftwood>

On Tue, Sep 24, 2013 at 04:23:48PM -0500, Rob Landley wrote:
> What value is there in requiring the new toolchain? From what I could  
> see of the commits it was micro-optimizations around memory barriers.
>
> *shrug* I can revert the patch locally, or patch the extra instruction  
> into my toolchain. But I do object to changing the documentation  
> globally for every architecture because one architecture did something  
> they apparently never thought through (or they'd have commented in the  
> commit that it requires a big toolchain version jump; pretty sure they  
> didn't actually notice).

Some of us are notoriously slow at updating our toolchains.  I'm still
using gcc 4.5.4 here, and people regard that as bordering on "too old"
because of the amount of warnings it spits out.  Binutils?  I upgraded
to 2.22 when I needed to fix a problem I was having with the previous
binutils I was using (I think that was 2.18).

I generally don't touch my toolchain unless there's a _reason_ I need
to, and as I've already updated to 2.22, it's a normally a pretty safe
bet that everyone else is already using 2.22 or later.  One reason for
this is that I don't want to be messing around trying to work out
whether a bug I'm seeing is because of a toolchain problem or something
in the kernel.

I realised at the time that I'm going to got shouted at if I accepted
the patches by a minority who wanted to keep their old toolchains, but
I also realise that if I don't accept the patches, I'll get shouted at
by another group.  It's the classic damned if I do and damned if I
don't.  So I've chosen the lesser of the two weavels.

Now, if you feel strongly about this, we _could_ introduce a
CONFIG_OLD_BINUTILS and give everyone their cake - but it will be
fragile.  Not everyone will remember to get that right, because they'll
be using the later binutils.  Also, we already have an excessive number
of potential breakage-inducing options and we certainly don't need
another.

Use IS_ENABLED() I hear you say.  That won't get the one dsb instruction
in some SoC code which was missed which will break the build on older
toolchains.

  reply	other threads:[~2013-09-24 21:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19  9:30 3.12-rc1: no longer compiles for Nokia n900 (omap based) Pavel Machek
2013-09-19  9:36 ` Will Deacon
2013-09-19  9:57   ` Pavel Machek
2013-09-23 23:59   ` new binutils needed for arm in 3.12-rc1 Pavel Machek
2013-09-24  2:13     ` Rob Landley
2013-09-24 12:11       ` Måns Rullgård
2013-09-24 21:23         ` Rob Landley
2013-09-24 21:48           ` Russell King - ARM Linux [this message]
2013-09-25  1:13             ` Rob Landley
2013-09-25  2:07               ` Nicolas Pitre
2013-09-25 15:23                 ` Rob Landley
2013-09-25 15:52                   ` Måns Rullgård
2013-09-26  0:10                     ` Rob Landley
2013-09-26 22:24                       ` Måns Rullgård
2013-09-25 16:13                   ` Nicolas Pitre
2013-09-26 22:48                     ` Rob Landley
2013-09-27 19:41                       ` Pavel Machek
2013-09-28  8:43                       ` Pavel Machek
2013-09-25 20:44                   ` Russell King - ARM Linux
2013-09-25 20:49                     ` Måns Rullgård
2013-09-26 22:50                       ` Rob Landley
2013-09-26  7:18               ` Geert Uytterhoeven
2013-09-28  9:03                 ` richard -rw- weinberger
2013-09-24  2:20     ` Rob Landley
2013-09-19  9:44 ` 3.12-rc1: no longer compiles for Nokia n900 (omap based), display no longer works Pavel Machek
2013-09-19 18:47   ` Aaro Koskinen
2013-09-26  0:23     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130924214800.GV25647@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Catalin.Marinas@arm.com \
    --cc=akpm@osdl.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=pavel@ucw.cz \
    --cc=rob@landley.net \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).