From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit
 declarations.
Date: Tue, 8 Oct 2013 11:05:26 -0700
Message-ID: <20131008180526.GD8313@atomide.com>
References: <1381228141-16213-1-git-send-email-csmanjuvijay@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1381228141-16213-1-git-send-email-csmanjuvijay@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Majunath Goudar <csmanjuvijay@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, nataraja.km@lge.com, Russell King <linux@arm.linux.org.uk>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
List-Id: linux-omap@vger.kernel.org

* Majunath Goudar <csmanjuvijay@gmail.com> [131008 03:37]:
> This patch adds a omap1510_fpga_init_irq() inline dummy implementatio=
ns
> in arch/arm/mach-omap1/common.h. Without this patch,build system can
> lead to issues. This was discovered during randconfig testing,in whic=
h
> other than CONFIG_ARCH_OMAP15XX was enabled the leading to the follow=
ing
> error:
>=20
> CC      arch/arm/mach-omap1/board-innovator.o
> arch/arm/mach-omap1/board-innovator.c: In function =E2=80=98innovator=
_init=E2=80=99:
> arch/arm/mach-omap1/board-innovator.c:377:3: error: implicit declarat=
ion of
> function =E2=80=98omap1510_fpga_init_irq=E2=80=99 [-Werror=3Dimplicit=
-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [arch/arm/mach-omap1/board-innovator.o] Error 1
> make: *** [arch/arm/mach-omap1] Error 2

Thanks, I'll apply this into omap-for-v3.13/fixes-not-urgent
as it's been there for quite a while.

Regards,

Tony
=20
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> ---
>  arch/arm/mach-omap1/common.h |    3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/commo=
n.h
> index abec019..732f8ee 100644
> --- a/arch/arm/mach-omap1/common.h
> +++ b/arch/arm/mach-omap1/common.h
> @@ -46,6 +46,9 @@ static inline void omap7xx_map_io(void)
>  void omap1510_fpga_init_irq(void);
>  void omap15xx_map_io(void);
>  #else
> +static inline void omap1510_fpga_init_irq(void)
> +{
> +}
>  static inline void omap15xx_map_io(void)
>  {
>  }
> --=20
> 1.7.9.5
>=20