From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Afzal Mohammed <afzal@ti.com>, Tero Kristo <t-kristo@ti.com>,
Rajendra Nayak <rnayak@ti.com>, Nishant Menon <nm@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: hwmod: check for module address space during init
Date: Tue, 8 Oct 2013 11:09:36 -0700 [thread overview]
Message-ID: <20131008180936.GE8313@atomide.com> (raw)
In-Reply-To: <1380819546-53631-1-git-send-email-s-anna@ti.com>
* Suman Anna <s-anna@ti.com> [131003 10:07]:
> The hwmod init sequence involves initializing and idling all the
> hwmods during bootup. If a module class has sysconfig, the init
> sequence utilizes the module register base for performing any
> sysc configuration.
>
> The module address space is being removed from hwmod database and
> retrieved from the <reg> property of the corresponding DT node.
> If a hwmod does not have its corresponding DT node defined and the
> memory address space is not defined in the corresponding
> omap_hwmod_ocp_if, then the module register target address space
> would be NULL and any sysc programming would result in a NULL
> pointer dereference and a kernel boot hang.
Hmm so is this needed as a fix for the -rcy cycle?
Other than that looks OK to me, Paul should queue or ack this one:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-10-08 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 16:59 [PATCH] ARM: OMAP2+: hwmod: check for module address space during init Suman Anna
2013-10-03 17:05 ` Santosh Shilimkar
2013-10-07 21:19 ` Nishanth Menon
2013-10-07 22:04 ` Suman Anna
2013-10-08 18:09 ` Tony Lindgren [this message]
2013-10-08 21:44 ` Suman Anna
2013-10-09 5:35 ` Paul Walmsley
2013-10-09 17:54 ` Suman Anna
-- strict thread matches above, loose matches on Subject: below --
2013-11-20 22:14 Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008180936.GE8313@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=s-anna@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).