From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v5 00/11] ARM: OMAP2+: AM43x PRCM basic support Date: Tue, 8 Oct 2013 11:15:35 -0700 Message-ID: <20131008181535.GF8313@atomide.com> References: <524E6346.2080208@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:40154 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415Ab3JHSPj (ORCPT ); Tue, 8 Oct 2013 14:15:39 -0400 Content-Disposition: inline In-Reply-To: <524E6346.2080208@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: Afzal Mohammed , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paul Walmsley , Benoit Cousson * Rajendra Nayak [131003 23:50]: > On Tuesday 01 October 2013 12:34 PM, Afzal Mohammed wrote: > > Hi Paul, Benoit, Tony, > > > > This series adds PRCM support (except clock tree) for AM43x SoC's. > > Please consider this for inclusion in the coming merge window. > > > > Patch 02/11 "ARM: OMAP2+: hwmod: AM335x/AM43x: move common data" may > > not reach mailing lists due to bigger size, this series is also present > > @git://gitorious.org/x0148406-public/linux-kernel.git tags/am43x-prcm-v5 > > > > Compared to v4, only change is in fixing the powerdomain data. > > > > Major changes compared to rfc v3: > > 1. All register offsets properly taken care for AM43x (with rfc v3, a > > couple of issues was detected while testing on pre-silicon) > > 2. There were two patches for common hwmod data movement (one for > > interconnect and other for ip block data), both were combined to have > > a cleaner series that is bisectable. > > 3. Cleaner seperation of common data > > > > Major changes compared to v2 (v3 was only an rfc for current approach): > > 1. omap_hwmod_33xx_43xx_interconnect_data.c has the common interconnect > > ocp's structs shared between AM335x and AM43x > > 2. omap_hwmod_33xx_43xx_ipblock_data.c has the common hwmod structs > > shared between AM335x and AM43x > > This split and reuse looks much better and readable now. > > For the complete series, > Acked-by: Rajendra Nayak Looks good to me too. I'm assuming that Paul will queue this. And let's everybody make note that this will be the _last_ set of hwmod data we'll _ever_ merge as this all should be replaced with device tree + bus driver based approach for future SoCs. But let's get the common clock framework conversion done first, so this can wait until after that. Acked-by: Tony Lindgren