From: Tony Lindgren <tony@atomide.com>
To: joerg Reisenweber <joerg@openmoko.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Russell King" <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Tue, 8 Oct 2013 11:29:45 -0700 [thread overview]
Message-ID: <20131008182945.GI8313@atomide.com> (raw)
In-Reply-To: <201309231506.37942.joerg@openmoko.org>
* joerg Reisenweber <joerg@openmoko.org> [130923 06:14]:
> On Mon 23 September 2013 14:50:12 Pali Rohár wrote:
> > Hi Tony,
> >
> > here is new version (v2) of patch which adding max_current values to rx51
> > board data. According to joerg safe value for max_current is 100 (10 mA).
> >
> >
> > RX-51: Add missing max_current to rx51_lp5523_led_config
> >
> > File drivers/leds/leds-lp55xx-common.c refuse to change led_current sysfs
> > attribute if value is higher than max_current specified in board file. By
> > default global C variables are zero, so changing always failed. This patch
> > adding missing max_current and setting it to max safe value 100 (10 mA).
...
> Reviewed and found logically and technically correct
> Signed-off-by: Joerg Reisenweber <joerg AT openmoko DOT org>
Thanks, I'll apply this into omap-for-v3.12/fixes as it's a
regression.
Regards,
Tony
prev parent reply other threads:[~2013-10-08 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 21:52 [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config Pali Rohár
2013-09-18 22:26 ` Tony Lindgren
2013-09-19 21:01 ` Pali Rohár
2013-09-19 21:29 ` Tony Lindgren
2013-09-19 22:20 ` Pali Rohár
2013-09-23 12:50 ` [PATCH v2] " Pali Rohár
2013-09-23 13:06 ` joerg Reisenweber
2013-10-08 18:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008182945.GI8313@atomide.com \
--to=tony@atomide.com \
--cc=joerg@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).