From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Archit Taneja <archit@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 0/4] arm: omap: display: Ensure DRM/FB/V4L devices are created if DSS is available
Date: Tue, 8 Oct 2013 14:06:25 -0700 [thread overview]
Message-ID: <20131008210625.GP8313@atomide.com> (raw)
In-Reply-To: <5236C63A.9000709@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [130916 01:57]:
> On 16/09/13 10:18, Archit Taneja wrote:
> > Currently, omapdrm, omapfb and omap_vout platform devices are created and
> > registered through omap_arch_initcalls. In a multiplatform config. It's
> > possible that all the corresponding configs for the above drivers along with
> > omapdss config are selected even if the hardware doesn't have a DSS IP.
> >
> > If the image is booted on a AM33xx platform, the above drm, fb and v4l devices
> > would be registered throuth the omap_arch_initcalls even if omapdss itself isn't
> > registered. These platform devices don't cause any harm, but are unnecessary.
> >
> > Move the registration of these devices into omap_display_init(), which registers
> > omapdss devices and is called only if the platform has DSS hardware.
> >
> > Also, the first patch prevents creation of a DMM device when omapdrm device is
> > registered. With the removal of address and irq data from the omap4 hwmods, the
> > probe of DMM driver fails and omapdrm isn't able to utilize the DMM hardware.
> > This will be fixed when DMM DT nodes are added for omap4, omap5 and dra7x.
> >
> > Changes in v2:
> > - Move device creation for omapfb and omap_vout to omap_display_init too.
> > - Keep the DMM DT conversion as a separate patch series since this series does
> > something different now.
> >
> > Archit Taneja (4):
> > arm: omap: drm: Don't build device for DMM
> > arm: omap: display: Create omapdrm device inside omap_display_init
> > arm: omap: display: Create omapvrfb and omapfb devices inside
> > omap_display_init
> > arm: omap: display: Create omap_vout device inside omap_display_init
> >
> > arch/arm/mach-omap2/Makefile | 6 +-----
> > arch/arm/mach-omap2/devices.c | 10 +++++-----
> > arch/arm/mach-omap2/display.c | 28 ++++++++++++++++++++++++++++
> > arch/arm/mach-omap2/display.h | 4 ++++
> > arch/arm/mach-omap2/drm.c | 24 +++++-------------------
> > arch/arm/mach-omap2/fb.c | 14 +++++++-------
> > 6 files changed, 50 insertions(+), 36 deletions(-)
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Tony, since there are no driver changes here, and it's unlikely that
> we'd have a conflict between the dss driver changes and these changes, I
> think it's best if this goes through linux-omap.
OK applying into omap-for-v3.13/display, thanks.
Tony
prev parent reply other threads:[~2013-10-08 21:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 7:18 [PATCH v2 0/4] arm: omap: display: Ensure DRM/FB/V4L devices are created if DSS is available Archit Taneja
2013-09-16 7:18 ` [PATCH v2 1/4] arm: omap: drm: Don't build device for DMM Archit Taneja
2013-09-16 7:18 ` [PATCH v2 2/4] arm: omap: display: Create omapdrm device inside omap_display_init Archit Taneja
2013-09-16 7:18 ` [PATCH v2 3/4] arm: omap: display: Create omapvrfb and omapfb devices " Archit Taneja
2013-09-16 7:18 ` [PATCH v2 4/4] arm: omap: display: Create omap_vout device " Archit Taneja
2013-09-16 8:50 ` [PATCH v2 0/4] arm: omap: display: Ensure DRM/FB/V4L devices are created if DSS is available Tomi Valkeinen
2013-10-08 21:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008210625.GP8313@atomide.com \
--to=tony@atomide.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).