From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH] clk: add flags to distinguish xtal clocks Date: Mon, 11 Nov 2013 13:43:55 -0600 Message-ID: <20131111194355.GC19212@saruman.home> References: <1382528150.21526.25.camel@porter.coelho.fi> <1383933648-28595-1-git-send-email-balbi@ti.com> <5281058E.5050607@wwwdotorg.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:52979 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476Ab3KKTon (ORCPT ); Mon, 11 Nov 2013 14:44:43 -0500 Content-Disposition: inline In-Reply-To: <5281058E.5050607@wwwdotorg.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Stephen Warren Cc: Felipe Balbi , mturquette@linaro.org, Linux ARM Kernel Mailing List , Linux OMAP Mailing List , Linux Kernel Mailing List , james.hogan@imgtec.com, luca@coelho.fi --96YOpH+ONegL0A3E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Nov 11, 2013 at 09:27:58AM -0700, Stephen Warren wrote: > On 11/08/2013 11:00 AM, Felipe Balbi wrote: > > From: Luciano Coelho > >=20 > > Add a flag that indicate whether the clock is a crystal or not. > >=20 > > Additionally, parse a new device tree binding in clk-fixed-rate to set > > this flag. > >=20 > > If clock-xtal isn't set, the clock framework will assume clock to be > > generated by an oscillator. There's only one user for this binding > > right now which is Texas Instruments' WiLink devices which need to know > > details about the clock in order to initialize the underlying WiFi HW > > correctly. >=20 > Why on earth does it care? Surely the WiFi HW doesn't care about > crystal-vs-non-crystal, but rather some facet of the clock signal that > the type of source implies. Shouldn't the DT property describe that > facet of the signal, rather than the reason why it has that facet? well, if you can figure out what that facet is, then _do_ tell. Luca has tried for months to get that information with no success. --=20 balbi --96YOpH+ONegL0A3E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSgTN7AAoJEIaOsuA1yqREllEP/1a/xP7xi3rTdHjbJAkNAOjW sc4pxSRnx8YF9b7Gmxkx30sJjcbsPejhKB8Vup4FfXQVXbTN8YwQ+M+KYclsgXDS A2dia2/Fde70QkKyf5lu5oHHdENTBt7b51y+FYpJpOslFS01uMUQ3DAi68jCs/Kx BeKzBIBK17Jx9oLNhL7kl0EDefrHo/KoyBSPpe4CCS4N4pHInZLsmjlNqZLXuhjg W72BxaJA636hB0rWWPF5tJt7JpM2r1A/hOYp/K4RZF+ACPn39d8z5nUAR3sZsQwG 36ecFFFM18O4Cus+IRkg2zuAQxW1et/PlDK84OC6TjMRK3KREJStrFH7eZ0cmq0N 3N4+ltfKtRRW4bcB2/CpjJpolPxxmCqU3GxGAOzXBK7LmDe7Ac2CrLXEw/fVQbVU luUfiqaAqjmsAD2fqCuWgO2eqQ9Jpy4aobFik6c5c2L2fKmVLimhW/sFl5f2Vlo+ giAWkPwC7r6whFoJLlTrX1KYnoQWrQQPaQAVtygxDyUHVQSvPDhmh1fHmXeMtx9S FXix4z4h9SRuEAqg3ziOTsE4WgH3jSLxLqgglum/ERbxsuFPoFfINosLRgMPkS4t 6NJ54Vxw/NktCbnGdgnIJZPnMTVV7by8gKkVqha5oSxx4/KeQ2K5ShmntLQPi+Ez WlfJgpL/6L1Ov3Di359L =ZMTS -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E--