Re: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

On Tue, Nov 12, 2013 at 02:56:47PM -0800, Brian Norris wrote:
> On Tue, Nov 12, 2013 at 05:45:56PM -0300, Ezequiel Garcia wrote:
> > On Fri, Oct 25, 2013 at 11:26:06AM +0000, Gupta, Pekon wrote:
> > > > From: Ezequiel Garcia [mailto:ezequiel.garcia@free-electrons.com]
> > > > Subject: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option
> > > > dependency
> > > > 
> > > > This option does not need to depend in MTD_NAND, for it's enclosed
> > > > under it. Also, it's wrong to make it depend in ARCH_OMAP3 only
> > > > since the controller is used in a wider range of SoCs.
> > > > 
> > > > Instead, just leave the dependency on the OMAP2 driver option.
> > > > 
> > > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > > > ---
> > > >  drivers/mtd/nand/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > > > index d885298..8187466 100644
> > > > --- a/drivers/mtd/nand/Kconfig
> > > > +++ b/drivers/mtd/nand/Kconfig
> > > > @@ -95,7 +95,7 @@ config MTD_NAND_OMAP2
> > > >  	  platforms.
> > > > 
> > > >  config MTD_NAND_OMAP_BCH
> > > > -	depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3
> > > > +	depends on MTD_NAND_OMAP2
> > > >  	tristate "Enable support for hardware BCH error correction"
> > > >  	default n
> > > >  	select BCH
> > > > --
> > > > 1.8.1.5
> > > 
> > > Acked-by: Pekon Gupta <pekon@ti.com>
> > 
> > Brian,
> > 
> > I almost forgot about this one, and I just came across the issue
> > while configuring my board.
> > 
> > I believe this one is simple enough to be pulled in for v3.14
> > (it could be in v3.13, but it's already too late).
> > 
> > Or maybe you're not taking stuff for v3.14 yet...
> 
> Thanks for the reminder. The rest of the series has been discussed
> separately or is otherwise superceded by other patch series, right?
> 

The rest of the series can be divided in two groups:

1. Trivial stuff: I'll sent re-based patches on top of v3.13-rc1
or maybe Pekon will take care of it. It's not a big deal.

2. The ONFI detection stuff: it's not trivial and it's still under
discussion in separate threads. The last work was suggested by Pekon
in his last mail, and I guess he'll post a separate patch soon.

> Applied this one patch to l2-mtd.git, branch 'next'. Thanks.

Great, thanks.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html