* [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init()
@ 2013-10-25 9:31 Wei Yongjun
2013-11-03 9:50 ` Igor Grinberg
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-10-25 9:31 UTC (permalink / raw)
To: khilman, tony, linux; +Cc: yongjun_wei, linux-omap, linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function platform_device_register_resndata()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-omap2/gpmc-smsc911x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c b/arch/arm/mach-omap2/gpmc-smsc911x.c
index ef99011..2757504 100644
--- a/arch/arm/mach-omap2/gpmc-smsc911x.c
+++ b/arch/arm/mach-omap2/gpmc-smsc911x.c
@@ -83,7 +83,7 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *gpmc_cfg)
pdev = platform_device_register_resndata(NULL, "smsc911x", gpmc_cfg->id,
gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources),
&gpmc_smsc911x_config, sizeof(gpmc_smsc911x_config));
- if (!pdev) {
+ if (IS_ERR(pdev)) {
pr_err("Unable to register platform device\n");
gpio_free(gpmc_cfg->gpio_reset);
goto free2;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init()
2013-10-25 9:31 [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init() Wei Yongjun
@ 2013-11-03 9:50 ` Igor Grinberg
2013-11-14 18:41 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Igor Grinberg @ 2013-11-03 9:50 UTC (permalink / raw)
To: Wei Yongjun
Cc: khilman, tony, linux, yongjun_wei, linux-omap, linux-arm-kernel
On 10/25/13 11:31, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function platform_device_register_resndata()
> returns ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> arch/arm/mach-omap2/gpmc-smsc911x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c b/arch/arm/mach-omap2/gpmc-smsc911x.c
> index ef99011..2757504 100644
> --- a/arch/arm/mach-omap2/gpmc-smsc911x.c
> +++ b/arch/arm/mach-omap2/gpmc-smsc911x.c
> @@ -83,7 +83,7 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *gpmc_cfg)
> pdev = platform_device_register_resndata(NULL, "smsc911x", gpmc_cfg->id,
> gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources),
> &gpmc_smsc911x_config, sizeof(gpmc_smsc911x_config));
> - if (!pdev) {
> + if (IS_ERR(pdev)) {
> pr_err("Unable to register platform device\n");
> gpio_free(gpmc_cfg->gpio_reset);
> goto free2;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init()
2013-11-03 9:50 ` Igor Grinberg
@ 2013-11-14 18:41 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2013-11-14 18:41 UTC (permalink / raw)
To: Igor Grinberg
Cc: Wei Yongjun, khilman, linux, yongjun_wei, linux-omap,
linux-arm-kernel
* Igor Grinberg <grinberg@compulab.co.il> [131103 01:50]:
> On 10/25/13 11:31, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > In case of error, the function platform_device_register_resndata()
> > returns ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Thanks applying into omap-for-v3.13/fixes.
Tony
> > ---
> > arch/arm/mach-omap2/gpmc-smsc911x.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/gpmc-smsc911x.c b/arch/arm/mach-omap2/gpmc-smsc911x.c
> > index ef99011..2757504 100644
> > --- a/arch/arm/mach-omap2/gpmc-smsc911x.c
> > +++ b/arch/arm/mach-omap2/gpmc-smsc911x.c
> > @@ -83,7 +83,7 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *gpmc_cfg)
> > pdev = platform_device_register_resndata(NULL, "smsc911x", gpmc_cfg->id,
> > gpmc_smsc911x_resources, ARRAY_SIZE(gpmc_smsc911x_resources),
> > &gpmc_smsc911x_config, sizeof(gpmc_smsc911x_config));
> > - if (!pdev) {
> > + if (IS_ERR(pdev)) {
> > pr_err("Unable to register platform device\n");
> > gpio_free(gpmc_cfg->gpio_reset);
> > goto free2;
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> --
> Regards,
> Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-14 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 9:31 [PATCH] ARM: OMAP2+: smsc911x: fix return value check in gpmc_smsc911x_init() Wei Yongjun
2013-11-03 9:50 ` Igor Grinberg
2013-11-14 18:41 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).