From: Sebastian Reichel <sre@ring0.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
bcousson@baylibre.com, tomi.valkeinen@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 11/11] OMAPDSS: DPI: use VPLL2 regulator if VDDS_DSI is not found
Date: Sat, 16 Nov 2013 16:02:35 +0000 [thread overview]
Message-ID: <20131116160234.GB5104@earth.universe> (raw)
In-Reply-To: <20131116154507.GL10317@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Sat, Nov 16, 2013 at 07:45:07AM -0800, Tony Lindgren wrote:
> Well let's see what Tomi prefers.
>
> > > &vaux1 {
> > > /* Needed for ads7846 */
> > > regulator-name = "vcc";
> > > };
> > >
> > > &vpll2 {
> > > /* Needed for DSS */
> > > regulator-name = "vdds_dsi";
> > > };
>
> In the long we'll use regulator phandles anyways in the DSS related
> nodes, so from that point of view fixing dpi.c makes sense.
The hack, as being sent by Javier, will result in the wrong
regulator being used on the Nokia N900, which is using vaux1.
It must depend on the machine.
At the same time the N900 device tree file uses V28 as
regulator-name for vaux1 (which is the same one as legacy boot
used). Nothing depends on this, but I don't think it's a
good idea to use this property. Apparently it does not work
if multiple drivers need the same regulator under different
names.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-16 16:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 13:23 [PATCH 00/11]: add remaining support for IGEP boards Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 01/11] ARM: dts: omap3-igep: Fix bus-width for mmc1 Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 02/11] ARM: dts: omap3-igep: Add support for LBEE1USJYC WiFi connected to SDIO Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 03/11] ARM: dts: omap3-igep: Update to use the TI AM/DM37x processor Javier Martinez Canillas
2013-11-16 14:44 ` Tony Lindgren
2013-11-16 15:19 ` Javier Martinez Canillas
2013-11-16 15:22 ` Tony Lindgren
2013-11-16 13:23 ` [PATCH 04/11] ARM: dts: omap3-igep0020: Add pinmux setup for i2c devices Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 05/11] ARM: dts: omap3-igep0020: Add pinmuxing for DVI output Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 06/11] ARM: dts: AM33XX BASE0033: add pinmux and hdmi node to enable display Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 07/11] ARM: dts: AM33XX BASE0033: add pinmux and user led support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 08/11] ARM: dts: AM33XX BASE0033: add 32KBit EEPROM support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 09/11] ARM: dts: AM33XX IGEP0033: add USB support Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 10/11] ARM: OMAP: dss-common: change IGEP's DVI DDC i2c bus Javier Martinez Canillas
2013-11-16 13:23 ` [PATCH 11/11] OMAPDSS: DPI: use VPLL2 regulator if VDDS_DSI is not found Javier Martinez Canillas
2013-11-16 14:18 ` Tony Lindgren
2013-11-16 15:34 ` Javier Martinez Canillas
2013-11-16 15:45 ` Tony Lindgren
2013-11-16 16:02 ` Sebastian Reichel [this message]
2013-11-16 17:28 ` Javier Martinez Canillas
2013-11-17 0:26 ` Sebastian Reichel
2013-11-17 1:06 ` Javier Martinez Canillas
2013-11-16 14:16 ` [PATCH 00/11]: add remaining support for IGEP boards Tony Lindgren
2013-11-16 14:41 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131116160234.GB5104@earth.universe \
--to=sre@ring0.de \
--cc=bcousson@baylibre.com \
--cc=eballetbo@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).