From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode Date: Sun, 24 Nov 2013 20:01:16 +0100 Message-ID: <201311242001.16299@pali> References: <1378630239-10006-1-git-send-email-pali.rohar@gmail.com> <1384856285-19593-3-git-send-email-pali.rohar@gmail.com> <20131124165959.GA655@earth.universe> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6393481.xzxlF9Hhgc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f41.google.com ([209.85.214.41]:40458 "EHLO mail-bk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117Ab3KXTBU (ORCPT ); Sun, 24 Nov 2013 14:01:20 -0500 In-Reply-To: <20131124165959.GA655@earth.universe> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Anton Vorontsov , David Woodhouse , Tony Lindgren , Russell King , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, freemangordon@abv.bg, aaro.koskinen@iki.fi, pavel@ucw.cz --nextPart6393481.xzxlF9Hhgc Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 24 November 2013 18:00:00 Sebastian Reichel wrote: > Hi, >=20 > On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Roh=C3=A1r wrote: > > This patch removing set_mode_hook function from board data > > and replacing it with new string variable of notifier power > > supply device. After this change it is possible to add DT > > support because driver does not need specific board > > function anymore. Only static data and name of power supply > > device is required. >=20 > I'm wondering if the watchdog thread should check some values, > like e.g. battery temperature. It should stop charging the > battery if some critical battery temperature threshold is > reached. >=20 > -- Sebastian =46or checking battery temperature is needed third driver=20 (rx51_battery.ko). And I think this should not be implemented in=20 driver itself but in charger manager framework... Currently on Maemo 5 this is handled in userspace (with open=20 source dsme daemon). =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart6393481.xzxlF9Hhgc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlKSTPwACgkQi/DJPQPkQ1KLHgCgrqxHcBZaRRQAJ8mSPELssg9j Tn8AnjBGx6snq5+26d7tOrV8GKv7KHgB =QcMP -----END PGP SIGNATURE----- --nextPart6393481.xzxlF9Hhgc--