From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: "Gupta, Pekon" <pekon@ti.com>,
"Javier Martinez Canillas" <javier@dowhile0.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Javier Martinez Canillas" <martinez.javier@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Rini, Tom" <trini@ti.com>,
"Scott Wood (scottwood@freescale.com)" <scottwood@freescale.com>
Subject: Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.
Date: Mon, 2 Dec 2013 16:51:03 +0100 [thread overview]
Message-ID: <20131202165103.726314d9@skate> (raw)
In-Reply-To: <CAFqH_52ARf44fWOP9HBwfS=AjoNm2MfEMyBBAJ7KDJO+xLPGfw@mail.gmail.com>
Dear Enric Balletbo Serra,
On Mon, 2 Dec 2013 16:39:09 +0100, Enric Balletbo Serra wrote:
> Thanks for the explanations to all.
>
> Although the new ECC schema breaks the compatibility between the board
> files and new DT based kernel, I think we should use BCH8 scheme.
> Sorry, because I had not realized that this was configurable in
> u-boot, so I think, if Thomas is also agree, the better fix in that
> case is change CONFIG_NAND_OMAP_ECCSCHEME to
> OMAP_ECC_BCH8_CODE_HW_DETECTION_SW in u-boot. If this works we can
> discard this patch.
I theoretically don't have anything against that, but if I do this
change in U-Boot, and then use U-Boot to reflash to NAND the SPL and
U-Boot itself, will the OMAP ROM code still be able to read the SPL
from NAND ? I'm not sure which ECC scheme does the OMAP ROM code
support, and how it detects (or not) which ECC scheme to use to read
the SPL.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-02 15:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 11:23 [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility Enric Balletbo i Serra
2013-12-01 12:27 ` Javier Martinez Canillas
2013-12-02 10:54 ` Thomas Petazzoni
2013-12-02 14:16 ` Enric Balletbo Serra
2013-12-02 14:56 ` Gupta, Pekon
2013-12-02 15:02 ` Thomas Petazzoni
2013-12-02 15:19 ` Gupta, Pekon
2013-12-02 15:39 ` Enric Balletbo Serra
2013-12-02 15:51 ` Thomas Petazzoni [this message]
2013-12-02 16:00 ` Tom Rini
2013-12-02 16:06 ` Thomas Petazzoni
2013-12-02 16:13 ` Gupta, Pekon
2013-12-02 16:19 ` Thomas Petazzoni
2013-12-02 17:05 ` Gupta, Pekon
2013-12-02 17:16 ` Michael Trimarchi
2013-12-02 17:46 ` Gupta, Pekon
2013-12-02 18:09 ` Tom Rini
2013-12-02 17:25 ` Tom Rini
2013-12-06 19:52 ` Scott Wood
2013-12-02 16:19 ` Tom Rini
2013-12-02 16:21 ` Javier Martinez Canillas
2013-12-02 16:24 ` Tom Rini
2013-12-02 16:46 ` Javier Martinez Canillas
2013-12-02 16:57 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202165103.726314d9@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=bcousson@baylibre.com \
--cc=eballetbo@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=javier@dowhile0.org \
--cc=linux-omap@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=pekon@ti.com \
--cc=scottwood@freescale.com \
--cc=tony@atomide.com \
--cc=trini@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).