From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Date: Tue, 3 Dec 2013 09:51:36 +0000 Message-ID: <20131203095136.GF11828@lee--X1> References: <1386042188-12246-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1386042188-12246-1-git-send-email-balbi@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: Linux OMAP Mailing List , Aaro Koskinen , sameo@linux.intel.com, Tony Lindgren , Linux ARM Kernel Mailing List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org The code looks mostly fine, but the implementation of the commit logs seems lazy. Please submit a v3 using coherent sentences with full explanations and correct punctuation. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog