From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <rogerq@ti.com>,
Javier Martinez Canillas <martinez.javier@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request
Date: Fri, 6 Dec 2013 19:03:33 -0300 [thread overview]
Message-ID: <20131206220332.GA2458@localhost> (raw)
In-Reply-To: <20131206201623.GB21086@saruman.home>
On Fri, Dec 06, 2013 at 02:16:23PM -0600, Felipe Balbi wrote:
> On Sat, Nov 30, 2013 at 07:45:05PM -0300, Ezequiel Garcia wrote:
> > On Thu, Nov 21, 2013 at 07:01:55AM -0600, Felipe Balbi wrote:
> > > On Thu, Nov 21, 2013 at 08:55:20AM -0300, Ezequiel Garcia wrote:
> > > > On Thu, Nov 21, 2013 at 12:44:51PM +0100, Sebastian Andrzej Siewior wrote:
> > > > > On 11/21/2013 12:30 PM, Ezequiel Garcia wrote:
> > > > > > Ah, good to know. That patch should be picked ASAP, without it the USB
> > > > > > in AM335x is broken. Is it already too late to -rc1?
> > > > > Yes.
> > > > >
> > > > > > Who is supposed to merge that? Greg?
> > > > >
> > > > > Felipe will start collecting fixes once -rc1 is out [0] so it should be
> > > > > part of -rc2.
> > > > >
> > > >
> > > > OK, fine by me. Please note that Felipe's commit is a much bigger (and
> > > > nicer) rework of the code, and that it doesn't clearly state it fixes
> > > > the current code.
> > > >
> > > > Felipe: Maybe you should add some message stating it fixes a regression?
> > >
> > > sure, makes sense. Sebastian had already mentioned it sounded too nice
> > > of a commit log ;-)
> > >
> >
> > I'm looking at -rc2 and it seems the fix was never pushed, so my board
> > is probably still broken :-(
> >
> > Can anybody _please_please_ fix the issue by merging some fix so we can
> > use USB with mainline?
>
> it's in Greg's tree
>
Yeah, I just saw the pull. Thanks for the notice! I'll re-test in -rc4
and let you know if I find any more problems.
FWIW, I'm not entirely happy with the solution. Probably being a bit
paranoid, but it seemed to me the fix could be smaller (and fix only
the problem) and then pospone your refactoring until v3.14.
Just my two cents and thanks again for the notice.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-12-06 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384984714-19860-1-git-send-email-ezequiel.garcia@free-electrons.com>
[not found] ` <1384984714-19860-1-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-11-20 22:02 ` [PATCH] usb: phy: am335x: Prevent GPIO reset line request Ezequiel Garcia
2013-11-21 8:16 ` Sebastian Andrzej Siewior
[not found] ` <528DC168.7090204-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-11-21 11:30 ` Ezequiel Garcia
2013-11-21 11:44 ` Sebastian Andrzej Siewior
2013-11-21 11:55 ` Ezequiel Garcia
2013-11-21 13:01 ` Felipe Balbi
2013-11-30 22:45 ` Ezequiel Garcia
2013-12-06 20:16 ` Felipe Balbi
2013-12-06 22:03 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206220332.GA2458@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=rogerq@ti.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).