From: Felipe Balbi <balbi@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver
Date: Sat, 7 Dec 2013 11:51:27 -0600 [thread overview]
Message-ID: <20131207175127.GA12628@saruman.home> (raw)
In-Reply-To: <20131207141623.GL30823@blackmetal.musicnaut.iki.fi>
[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]
Hi,
On Sat, Dec 07, 2013 at 04:16:23PM +0200, Aaro Koskinen wrote:
> > fixed it up with:
> >
> > diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> > index 7cf1766..8bb833e 100644
> > --- a/drivers/usb/phy/phy-tahvo.c
> > +++ b/drivers/usb/phy/phy-tahvo.c
> > @@ -368,7 +368,9 @@ static int tahvo_usb_probe(struct platform_device *pdev)
> >
> > tu->extcon.name = DRIVER_NAME;
> > tu->extcon.supported_cable = tahvo_cable;
> > - ret = extcon_dev_register(&tu->extcon, &pdev->dev);
> > + tu->extcon.dev.parent = &pdev->dev;
> > +
> > + ret = extcon_dev_register(&tu->extcon);
> > if (ret) {
> > dev_err(&pdev->dev, "could not register extcon device: %d\n",
> > ret);
> >
> > please make sure it still works with v3.13-rc2 + this patch.
>
> Yes, that works fine with 3.13-rc2. Sorry for this, I was accidentally
cool, thanks :-)
> testing & basing these patches on an old branch.
no problem, s**t happens to everybody :-)
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2013-12-07 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 14:13 [PATCH v4 0/4] USB: OMAP1: Tahvo USB support for 770 Aaro Koskinen
2013-12-06 14:13 ` [PATCH v4 2/4] USB: OMAP1: add extcon to platform data Aaro Koskinen
[not found] ` <1386339187-28466-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2013-12-06 14:13 ` [PATCH v4 1/4] ARM: OMAP1: USB: move omap_usb_config " Aaro Koskinen
2013-12-06 14:13 ` [PATCH v4 3/4] USB: OMAP1: OTG controller driver Aaro Koskinen
2013-12-06 14:13 ` [PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver Aaro Koskinen
2013-12-06 20:46 ` Felipe Balbi
2013-12-07 14:16 ` Aaro Koskinen
2013-12-07 17:51 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207175127.GA12628@saruman.home \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox