Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

Felipe Balbi
2013-12-10T16:34:30Z

[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]

On Tue, Dec 10, 2013 at 09:20:50AM +0000, Lee Jones wrote:
> > Introduce an irq_chip and irq_domain for menelaus driver. Following
> > patches will convert uses to traditional request_threaded_irq().
> >
> > While at that, some better error handling had to be added, so we could
> > free irq descs we allocated.
> >
> > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/mfd/menelaus.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++---
>
> <snip>
>
> > + irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0,
> > + &irq_domain_simple_ops, m);
>
> When will this driver become DT compliant?

when OMAP2 becomes DT-compliant. It still boots with legacy board-file +
platform_data.

> > + m->irq_base = irq_base;
> > +
> > + for (i = irq_base; i < irq_base + MENELAUS_NR_IRQS; i++) {
> > + irq_set_chip_data(i, m);
> > + irq_set_chip_and_handler(i, &menelaus_irq_chip,
> > + handle_simple_irq);
> > + irq_set_nested_thread(i, 1);
> > + set_irq_flags(i, IRQF_VALID);
>
> This assumes that this h/w only exists on ARM platforms. Is that true?

it was made *only* for Nokia to use on their ARM-only internet tablets.

--
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org