Re: [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions

Felipe Balbi
2013-12-10T16:32:49Z

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Tue, Dec 10, 2013 at 09:00:21AM +0000, Lee Jones wrote:
> On Mon, 09 Dec 2013, Felipe Balbi wrote:
>
> > Those functions are static and can receive a menelaus_chip pointer very
> > easily.
> >
> > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/mfd/menelaus.c | 57 ++++++++++++++++++++++++++------------------------
> > 1 file changed, 30 insertions(+), 27 deletions(-)
>
> Same here. I think this should be done in one fell swoop.

then it would become a much, much larger patch which would become a pain
to review.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]