Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Uwe Kleine-König
2013-12-11T09:44:40Z

On Mon, Dec 02, 2013 at 09:42:54PM -0600, Felipe Balbi wrote:
> we could build that as a driver.
What is "that". How can it not be a driver? Do you mean modular? In that
case there is no problem, the only thing that doesn't work is unloading
the module.

Best regards
Uwe

> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/mfd/menelaus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index ad25bfa..975ff9e 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -1262,7 +1262,7 @@ fail:
> return err;
> }
>
> -static int __exit menelaus_remove(struct i2c_client *client)
> +static int menelaus_remove(struct i2c_client *client)
> {
> struct menelaus_chip *menelaus = i2c_get_clientdata(client);
>
> @@ -1283,7 +1283,7 @@ static struct i2c_driver menelaus_i2c_driver = {
> .name = DRIVER_NAME,
> },
> .probe = menelaus_probe,
> - .remove = __exit_p(menelaus_remove),
> + .remove = menelaus_remove,
> .id_table = menelaus_id,
> };
>

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |