Re: [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq

Felipe Balbi
2013-12-10T16:31:24Z

[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]

Hi,

On Tue, Dec 10, 2013 at 09:32:13AM +0000, Lee Jones wrote:
> On Mon, 09 Dec 2013, Felipe Balbi wrote:
>
> > We don't need that extra workqueue when we have generic threaded irq
> > handlers support. This patch just moves over to threaded irqs and
> > deletes the unnecessary workqueue.
> >
> > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/mfd/menelaus.c | 29 ++++-------------------------
> > 1 file changed, 4 insertions(+), 25 deletions(-)
>
> <snip>
>
> > - err = request_irq(client->irq, menelaus_irq, 0,
> > - DRIVER_NAME, menelaus);
> > + err = request_threaded_irq(client->irq, NULL, menelaus_irq,
> > + IRQF_ONESHOT, DRIVER_NAME, menelaus);
>
> devm_* managed resources please.

that would be subject to another patch. One that converts to devm_* on
the entire driver.

--
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org