From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions Date: Tue, 10 Dec 2013 18:42:16 +0000 Message-ID: <20131210184216.GD2390@lee--X1> References: <20131209161422.GC24047@saruman.home> <1386606085-26838-1-git-send-email-balbi@ti.com> <1386606085-26838-8-git-send-email-balbi@ti.com> <20131210090021.GQ12675@lee--X1> <20131210163249.GF22750@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131210163249.GF22750@saruman.home> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: Tony Lindgren , Aaro Koskinen , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org On Tue, 10 Dec 2013, Felipe Balbi wrote: > On Tue, Dec 10, 2013 at 09:00:21AM +0000, Lee Jones wrote: > > On Mon, 09 Dec 2013, Felipe Balbi wrote: > >=20 > > > Those functions are static and can receive a menelaus_chip pointe= r very > > > easily. > > >=20 > > > Tested-by: Aaro Koskinen > > > Signed-off-by: Felipe Balbi > > > --- > > > drivers/mfd/menelaus.c | 57 ++++++++++++++++++++++++++----------= -------------- > > > 1 file changed, 30 insertions(+), 27 deletions(-) > >=20 > > Same here. I think this should be done in one fell swoop. >=20 > then it would become a much, much larger patch which would become a p= ain > to review. If the patch was doing lots of different things then I'd be inclined to agree, but although large, the changes here are pretty trivial. I tend to break up patches based on; subsystem, file, device (for platform/dts adaptions) and functionality. Rather than just because the 'lines changed' count is large. Please squash them and I'll review it. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog