From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain Date: Wed, 11 Dec 2013 09:06:45 +0000 Message-ID: <20131211090645.GA16780@lee--X1> References: <20131209161422.GC24047@saruman.home> <1386606085-26838-1-git-send-email-balbi@ti.com> <1386606085-26838-11-git-send-email-balbi@ti.com> <20131210092050.GT12675@lee--X1> <20131210163430.GG22750@saruman.home> <20131210183749.GC2390@lee--X1> <20131210184653.GN13171@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131210184653.GN13171@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Felipe Balbi , Aaro Koskinen , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org On Tue, 10 Dec 2013, Tony Lindgren wrote: > * Lee Jones [131210 10:39]: > > > > > Introduce an irq_chip and irq_domain for menelaus driver. Fol= lowing > > > > > patches will convert uses to traditional request_threaded_irq= (). > > > > >=20 > > > > > While at that, some better error handling had to be added, so= we could > > > > > free irq descs we allocated. > > > > >=20 > > > > > Tested-by: Aaro Koskinen > > > > > Signed-off-by: Felipe Balbi > > > > > --- > > > > > drivers/mfd/menelaus.c | 127 +++++++++++++++++++++++++++++++= +++++++++++++++--- > > > >=20 > > > > > > > >=20 > > > > > + irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0, > > > > > + &irq_domain_simple_ops, m); > > > >=20 > > > > When will this driver become DT compliant? > > >=20 > > > when OMAP2 becomes DT-compliant. It still boots with legacy board= -file + > > > platform_data. > >=20 > > Really? Tony, are there any plans to DT the platform? >=20 > Yeah and what Felipe is doing here is an important step towards that. > We'll be booting omap2 in DT only mode with v3.14 Okay, sounds good. Thanks for the clarification. > but we still need > to rely on some pdata quirks at least for the MMC because Menelaus > does not provide the needed regulator phandles for the .dts files for > the driver to use. I'll take your word for it. :) --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog