From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus Date: Wed, 11 Dec 2013 09:17:39 +0000 Message-ID: <20131211091739.GB16780@lee--X1> References: <20131209161422.GC24047@saruman.home> <1386606085-26838-1-git-send-email-balbi@ti.com> <1386606085-26838-7-git-send-email-balbi@ti.com> <20131210085701.GP12675@lee--X1> <20131210163220.GE22750@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yh0-f53.google.com ([209.85.213.53]:54016 "EHLO mail-yh0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873Ab3LKJRp (ORCPT ); Wed, 11 Dec 2013 04:17:45 -0500 Received: by mail-yh0-f53.google.com with SMTP id b20so4811466yha.12 for ; Wed, 11 Dec 2013 01:17:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131210163220.GE22750@saruman.home> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Tony Lindgren , Aaro Koskinen , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List On Tue, 10 Dec 2013, Felipe Balbi wrote: > On Tue, Dec 10, 2013 at 08:57:01AM +0000, Lee Jones wrote: > > > Pass a menelaus_chip pointer as argument to most functions so we = can > > > minimize the usage of the global the_menelaus pointer. > > >=20 > > > Tested-by: Aaro Koskinen > > > Signed-off-by: Felipe Balbi > > > --- > > > drivers/mfd/menelaus.c | 265 ++++++++++++++++++++++++++---------= -------------- > > > 1 file changed, 142 insertions(+), 123 deletions(-) > >=20 > > How is this different from patch 6? >=20 > have you read the patch ? patch 6 converts *only* enable/disable irq > functions. Well it actually converts menelaus_ack_irq() too, but that's not the point I was making. I can see that the 'code' is different, but the functionality of the patch is the same i.e. converting functions to pass around the menelaus_chip pointer for eradication of the_menelaus global pointer. I'm not concerned about the 'lines changed' count. The change your making is trivial, thus there is no requirement to split unnecessarily over 5 patches. Please squash them into a single functionality patch. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html