From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name. Date: Fri, 13 Dec 2013 09:36:36 -0800 Message-ID: <20131213173636.GG28184@atomide.com> References: <1386059589-4030-1-git-send-email-marek.belisko@open-nandra.com> <529D9D43.6040101@ti.com> <20131205184323.GF26766@atomide.com> <20131209175006.GD12527@atomide.com> <52AAF5E6.1050900@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52AAF5E6.1050900@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kishon Vijay Abraham I Cc: Russell King - ARM Linux , Belisko Marek , LKML , "Dr. H. Nikolaus Schaller" , "linux-omap@vger.kernel.org" , linux-arm-kernel List-Id: linux-omap@vger.kernel.org * Kishon Vijay Abraham I [131213 03:57]: > On Friday 13 December 2013 04:57 PM, Belisko Marek wrote: > > Kishon can you please comment on that? Would be possible to get your > > patch to 3.13 (I seen some comments from Felipe). > > I'm not sure as my patch modifies all the board files. There was initially some > confusion w.r.t when the board files will be dropped. But since board files > will still be there in 3.13, I'd recommend my patch [1] to be taken. Anyways > if you have tested my patch (series), pls give your Tested-by. > > Tony, summary of the issue.. > After the platform devices are created using PLATFORM_DEVID_AUTO, the > device names given in usb_bind_phy (in board file) does not match with > the actual device name causing the USB PHY library not to return the > PHY reference when the MUSB controller request for the PHY in the non-dt boot > case. So removed creating platform devices using PLATFORM_DEVID_AUTO in > omap2430.c. So had to make the corresponding changes in board files. OK. Can you please repost with a proper commit id for what caused the regression and summararize why it should be fixed this way. Something like: Commit abcd1234 (usb: blah foo bar) caused blah blah blah. Fix the issue with blah blah blah. Note that the board-*.c files will be removed soon, but for v3.13 we still support both legacy booting and device tree based booting and need to fix it. Regards, Tony > [1] -> http://lists.scusting.com/index.php?t=msg&th=375579&start=0&S=Google