Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Felipe Balbi
2013-12-10T16:37:54Z

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

Hi,

On Tue, Dec 10, 2013 at 08:50:07AM +0000, Lee Jones wrote:
> > > > > The code looks mostly fine, but the implementation of the commit logs
> > > > > seems lazy. Please submit a v3 using coherent sentences with full
> > > > > explanations and correct punctuation.
> > > >
> > > > example ?
> > >
> > > All of your commit messages.
> > >
> > > > that macro just helps removing some extra
> > >
> > > ^- Sentences start with an uppercase character.
> > >
> > > > line of code and hides ffs() calls.
> > > >
> > > > while at that, also fix a variable shadowing
> > >
> > > ^- Sentences start with an uppercase character.
> > >
> > > > bug where 'int irq' was being redeclared inside
> > > > inner loop while it was also argument to interrupt
> > > > handler.
> > >
> > > < --------------- 50 chars ----------------- >
> > >
> > > Please use the full 72 char (or there abouts) width of the buffer.
> >
> > I don't see any mention of punctuation problems, however. Also, you're
> > not complaining about the content at all, which tells me those sentences
> > aren't as incoherent as you claimed before.
>
> I didn't read them in any detail. I traversed through the patches and

so you gave review comments without actually reviewing ? how rude...

> saw that the formatting looked obscure on all of them. As I have come
> to expect more of your submissions, I provided a generic reply
> detailing how I expected the commit logs to be. I wasn't insinuated
> that you failed to meet all of the criteria, but they definitely fell
> short of the mark.

in what way ?

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]