Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Felipe Balbi
2013-12-09T16:14:22Z

[-- Attachment #1.1: Type: text/plain, Size: 1114 bytes --]

Hi,

On Mon, Dec 09, 2013 at 09:37:48AM +0000, Lee Jones wrote:
> > > The code looks mostly fine, but the implementation of the commit logs
> > > seems lazy. Please submit a v3 using coherent sentences with full
> > > explanations and correct punctuation.
> >
> > example ?
>
> All of your commit messages.
>
> > that macro just helps removing some extra
>
> ^- Sentences start with an uppercase character.
>
> > line of code and hides ffs() calls.
> >
> > while at that, also fix a variable shadowing
>
> ^- Sentences start with an uppercase character.
>
> > bug where 'int irq' was being redeclared inside
> > inner loop while it was also argument to interrupt
> > handler.
>
> < --------------- 50 chars ----------------- >
>
> Please use the full 72 char (or there abouts) width of the buffer.

I don't see any mention of punctuation problems, however. Also, you're
not complaining about the content at all, which tells me those sentences
aren't as incoherent as you claimed before. But fair enough, I'll fix
those up and add Aaro's Tested-by

--
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org