Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

Lee Jones
2013-12-11T09:06:45Z

On Tue, 10 Dec 2013, Tony Lindgren wrote:

> * Lee Jones <lee.jones@linaro.org> [131210 10:39]:
> > > > > Introduce an irq_chip and irq_domain for menelaus driver. Following
> > > > > patches will convert uses to traditional request_threaded_irq().
> > > > >
> > > > > While at that, some better error handling had to be added, so we could
> > > > > free irq descs we allocated.
> > > > >
> > > > > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > > ---
> > > > > drivers/mfd/menelaus.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++---
> > > >
> > > > <snip>
> > > >
> > > > > + irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0,
> > > > > + &irq_domain_simple_ops, m);
> > > >
> > > > When will this driver become DT compliant?
> > >
> > > when OMAP2 becomes DT-compliant. It still boots with legacy board-file +
> > > platform_data.
> >
> > Really? Tony, are there any plans to DT the platform?
>
> Yeah and what Felipe is doing here is an important step towards that.
> We'll be booting omap2 in DT only mode with v3.14

Okay, sounds good. Thanks for the clarification.

> but we still need
> to rely on some pdata quirks at least for the MMC because Menelaus
> does not provide the needed regulator phandles for the .dts files for
> the driver to use.

I'll take your word for it. :)

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog