From: Felipe Balbi <balbi@ti.com>
To: anaumann@ultratronik.de
Cc: notasas@gmail.com, linux-usb@vger.kernel.org, balbi@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.
Date: Wed, 18 Dec 2013 09:35:45 -0600 [thread overview]
Message-ID: <20131218153545.GA1593@saruman.home> (raw)
In-Reply-To: <1387298913-18823-1-git-send-email-anaumann@ultratronik.de>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hi,
On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaumann@ultratronik.de wrote:
> From: Andreas Naumann <anaumann@ultratronik.de>
>
> This is a hard to reproduce problem which leads to non-functional
> USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit
> e25bec160158abe86c276d7d206264afc3646281, which introduces save/restore
> of OTG_INTERFSEL over suspend.
> Since the resume function is also called early in driver init, it uses a
> non-initialized value (which is 0 and a non-supported setting in DM37xx
> for INTERFSEL). Shortly after the correct value is set. Apparently this
> works most time, but not always.
yeah, but the problem is not on the glue layer. The bug is omap_device
and pm_runtime not agreeing on device's state. I suppose there was a fix
for that recently in linux-omap@vger mailing list.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-18 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 16:48 [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL anaumann-ZKHRqZ6+gQUX0D0ZMPkEVw
2013-12-17 17:22 ` David Cohen
2013-12-18 7:41 ` Andreas Naumann
2013-12-18 11:28 ` Grazvydas Ignotas
2013-12-18 15:35 ` Felipe Balbi [this message]
[not found] ` <20131218153545.GA1593-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-18 23:40 ` Grazvydas Ignotas
2013-12-19 14:06 ` Andreas Naumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218153545.GA1593@saruman.home \
--to=balbi@ti.com \
--cc=anaumann@ultratronik.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).