Re: [RFC 4/5] usb: dwc3-exynos: enable async suspend/resume

From: Felipe Balbi <balbi@ti.com>
To: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>
Cc: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
	kgene.kim@samsung.com, sarah.a.sharp@linux.intel.com,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	joshi@samsung.com, balbi@ti.com, linux-kernel@vger.kernel.org,
	Andrew Bresticker <abrestic@chromium.org>,
	linux-samsung-soc@vger.kernel.org, stern@rowland.harvard.edu,
	gautam.vivek@samsung.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 4/5] usb: dwc3-exynos: enable async suspend/resume
Date: Wed, 18 Dec 2013 10:07:36 -0600	[thread overview]
Message-ID: <20131218160736.GD4970@saruman.home> (raw)
In-Reply-To: <1387363174-25942-4-git-send-email-yuvaraj.cd@samsung.com>

[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]

On Wed, Dec 18, 2013 at 04:09:33PM +0530, Yuvaraj Kumar C D wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
> 
> In addition to enabling async suspend/resume on the xhci-plat device,
> we must enable it for the dwc3-exynos platform device in order to make
> the full USB stack resume asynchronously.  Like the xhci-plat, ehci-s5p,
> and ohci-exynos drivers, there are no outside dependencies which would
> make resuming the dwc3-exynos driver asynchronously unsafe.
> 
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Reviewed-by: Julius Werner <jwerner@chromium.org>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 8b20c70..57431b7 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -155,6 +155,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
>  		goto err2;
>  	}
>  
> +	device_enable_async_suspend(dev);

sure that clk_disable() in your ->suspend() callback will cause no
issues at all ?

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel