From: "Pali Rohár" <pali.rohar@gmail.com>
To: Felipe Contreras <felipe.contreras@nokia.com>
Cc: linux-main <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Aliaksei Katovich <aliaksei.katovich@nokia.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] mfd: add bq2415x charger driver
Date: Tue, 06 Dec 2011 00:05:30 +0100 [thread overview]
Message-ID: <2013134.msetbOSBe8@pali-elitebook> (raw)
In-Reply-To: <1323124541-7590-1-git-send-email-felipe.contreras@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]
On Tuesday 06 December 2011 00:35:41 Felipe Contreras wrote:
> From: Aliaksei Katovich <aliaksei.katovich@nokia.com>
>
> Hi,
>
> The Nokia N900 has a bunch of stuff regarding the battery: bq27x00 to find
> out the status, and isp1704 to detect what kind of charger is connected to
> the USB port. However, that doesn't charge the battery.
>
> That's the job of bq24150. Up until now, this has been done by the closed
> and proprietary BME application from user-space, which sends i2c commands
> directly.
>
> Several people have tried to decipher what it's actually doing, and there
> are some simple user-space scripts that manage to achieve charging:
>
> http://enivax.net/jk/n900/charge21.sh.txt
>
> Aliaksei Katovich already sent a patch series, but they seem to be doing
> something completely different (wrong?).
>
> This simple driver does the work for me. It's doing basically the same as
> the user-space scripts, but a bit more aligned to the spec sheet[1], and a
> bit more understadable. It's a proof of concept, as it doesn't really
> change the voltage or amperage depending on the type of charger as it
> should, but it at least it achieves charging.
>
> I have never writen a driver, so don't hold on the comments :)
>
> Some inspiration from the code of Aliaksei Katovich.
>
> Cheers.
>
> [1] http://www.ti.com/lit/ds/symlink/bq24150.pdf
>
Hello,
I started writing other implementaion of bq2415x charger driver, which should
support also setting usb host mode. Code is still unfinished, but now is
devided into 2 parts: one power_supply driver and one driver which cover all
bq registers. See:
http://atrey.karlin.mff.cuni.cz/~pali/bq2415x/
Felipe Contreras, I think that my implementation is better - it will export
all bq registers (which is needed for hostmode boost) and will also register
regulator interface.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-12-05 23:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 22:35 [PATCH] mfd: add bq2415x charger driver Felipe Contreras
2011-12-05 22:51 ` Felipe Contreras
2011-12-05 23:05 ` Pali Rohár [this message]
2011-12-06 0:12 ` Felipe Contreras
2011-12-06 7:25 ` Pali Rohár
2011-12-06 10:58 ` Felipe Contreras
2011-12-06 13:27 ` Pali Rohár
2011-12-06 14:11 ` Felipe Contreras
2011-12-06 15:19 ` Pali Rohár
2011-12-06 11:25 ` Mark Brown
2011-12-06 2:17 ` Sebastian Reichel
2011-12-06 2:49 ` Felipe Contreras
2011-12-06 13:21 ` Sebastian Reichel
2011-12-06 13:50 ` Felipe Contreras
2011-12-06 13:34 ` Pali Rohár
2011-12-06 11:31 ` Mark Brown
2011-12-06 11:43 ` Felipe Contreras
2011-12-06 11:46 ` Mark Brown
2011-12-07 21:03 ` RFC: bq2415x_charger driver Pali Rohár
2011-12-07 21:25 ` Vladimir Zapolskiy
2011-12-07 21:40 ` Pali Rohár
2012-01-27 2:40 ` RFC 2: " Pali Rohár
2012-01-27 16:24 ` Mark Brown
2012-01-27 18:33 ` Pali Rohár
2012-01-27 19:22 ` Mark Brown
2012-01-27 20:40 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2013134.msetbOSBe8@pali-elitebook \
--to=pali.rohar@gmail.com \
--cc=aliaksei.katovich@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).