Re: [PATCH v3 1/4] ARM: dts: OMAP5: Add 60MHz clock reference to USB Host module

[Arnd Bergmann <arnd@arndb.de>]

On Tuesday 07 January 2014, Roger Quadros wrote:
> USB Host driver (drivers/mfd/omap-usb-host.c) expects the 60MHz
> reference clock to be named "init_60m_fclk". Provide this
> information.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/omap5.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 2f12a47..e0ab379 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -765,6 +765,8 @@
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges;
> +                       clocks = <&l3init_60m_fclk>;
> +                       clock-names = "init_60m_fclk";
>  
>                         usbhsohci: ohci@4a064800 {
>                                 compatible = "ti,ohci-omap3", "usb-ohci";

The bindings/mfd/omap-usb-host.txt file doesn't document any clocks.
Please create another patch to document the clock names in this binding
before you start putting them into the dtsi file. So far the clock
names are an implementation detail of Linux as they are not part
of the binding, and with your patch it becomes part of the ABI.

	Arnd