From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH RFC 00/26] Migrate more OMAP DMA code to DMA engine Date: Mon, 13 Jan 2014 09:37:45 -0800 Message-ID: <20140113173744.GA7746@atomide.com> References: <20140102150836.GA3826@n2100.arm.linux.org.uk> <20140108012110.GL5074@atomide.com> <20140109152437.GB27282@n2100.arm.linux.org.uk> <20140113141811.GD27282@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:29072 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752763AbaAMRhw (ORCPT ); Mon, 13 Jan 2014 12:37:52 -0500 Content-Disposition: inline In-Reply-To: <20140113141811.GD27282@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: dmaengine@vger.kernel.org, Vinod Koul , Dan Williams , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Russell King - ARM Linux [140113 08:48]: > On Thu, Jan 09, 2014 at 03:24:37PM +0000, Russell King - ARM Linux wr= ote: > > On Tue, Jan 07, 2014 at 05:21:11PM -0800, Tony Lindgren wrote: > > > * Russell King - ARM Linux [140102 07:11= ]: > > > > The following patch series moves code to setup the DMA hardware= and > > > > service interrupts from the hardware to the DMA engine driver. = This > > > > reduces the dependency on the legacy DMA implementation. > > > >=20 > > > > This series does not remove the channel allocation/freeing hook= s which > > > > are used to manage the allocation of physical channels - this i= s the > > > > next step in the evolution. > > > >=20 > > > > The patches which move the interrupt handling are currently les= s than > > > > perfect since they're writing to ENABLE_L0 under a different sp= inlock, > > > > and hence RFC only at the moment. > > >=20 > > > Nice to see this happening. These seem to work for me based on a = quick > > > try on omap2+, but on omap1 the build fails: > > >=20 > > > arch/arm/mach-omap1/dma.c: In function =E2=80=98dma_write=E2=80=99= : > > > arch/arm/mach-omap1/dma.c:186: error: =E2=80=98const struct omap_= dma_reg=E2=80=99 has no member named =E2=80=98size=E2=80=99 > >=20 > > Right, needs this incremental patch: > >=20 > > diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c > > index 3afde9628839..404f89e3eeb8 100644 > > --- a/arch/arm/mach-omap1/dma.c > > +++ b/arch/arm/mach-omap1/dma.c > > @@ -183,7 +183,7 @@ static inline void dma_write(u32 val, int reg, = int lch) > > addr +=3D reg_map[reg].stride * lch; > > =20 > > __raw_writew(val, addr); > > - if (reg_map[reg].size =3D=3D OMAP_DMA_REG_2X16BIT) > > + if (reg_map[reg].type =3D=3D OMAP_DMA_REG_2X16BIT) > > __raw_writew(val >> 16, addr + 2); > > } > > =20 > > @@ -196,7 +196,7 @@ static inline u32 dma_read(int reg, int lch) > > addr +=3D reg_map[reg].stride * lch; > > =20 > > val =3D __raw_readw(addr); > > - if (reg_map[reg].size =3D=3D OMAP_DMA_REG_2X16BIT) > > + if (reg_map[reg].type =3D=3D OMAP_DMA_REG_2X16BIT) > > val |=3D __raw_readw(addr + 2) << 16; > > =20 > > return val; > >=20 >=20 > Any news on this? Sorry for the delay, now getting this: arch/arm/mach-omap1/dma.c: In function =E2=80=98omap1_system_dma_init=E2= =80=99: arch/arm/mach-omap1/dma.c:368: error: =E2=80=98struct omap_dma_dev_attr= =E2=80=99 has no member named =E2=80=98chan=E2=80=99 Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html