linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Tero Kristo <t-kristo@ti.com>, Kevin Hilman <khilman@linaro.org>,
	kernel-build-reports@lists.linaro.org,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	Mike Turquette <mturquette@linaro.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	Olof Johansson <olof@lixom.net>, Ash Charles <ash@gumstix.com>
Subject: Re: next boot: 34 pass, 5 fail (next-20140122)
Date: Thu, 23 Jan 2014 09:35:00 -0800	[thread overview]
Message-ID: <20140123173500.GI7993@atomide.com> (raw)
In-Reply-To: <52E144BC.4000900@epfl.ch>

* Florian Vaussard <florian.vaussard@epfl.ch> [140123 08:37]:
> On 01/23/2014 01:27 PM, Tero Kristo wrote:
> >>>>>
> >>>>> The problem is that the Overo (processor card on the Tobi extension
> >>>>> board) can have a variety of processor depending on the exact model:
> >>>>>
> >>>>> - OMAP 35xx (1st generation: Air, Earth, Fire, Sand, Tide, Water, FE)
> >>>>> - OMAP 3730
> >>>>> - AM/DM 37xx

With the legacy booting, the real problem is that board-overo.c is
trying to boot all overos with just one machine ID. Tero's patch works
around that issue for legacy booting, but maybe it's best to do the SoC
detection in the board-*.c files in init_early as needed rather than
patch all the board-*.c files.

Sounds like we need to do the same for legacy booting for the original
beagle as well?

> Ok, so with your patch and changing the include from omap34xx to
> omap36xx, it works. Now I have to come up with a way to manage all the
> versions without duplicating all the DT files :-(

Yeah there's no quick fix here that's suitable in the long run. The
proper fix is to have minimal SoC specific .dts files for the
supported overo variants that include the common board specific
.dtsi file(s).

We did a similar thing recently for the compulab variants, see
commit 0f0cfc69547e (ARM: dts: Add support for sbc-3xxx with cm-t3730)
for example. Also take a look at the follo-up patches posted to
the mailing list.

With device tree based booting we don't want to build data into the
kernel for all the SoC variants for things like clocks, pinctrl and
hwmod. And we already need to define SoC specific things in the .dts
files for pinctrl with clocks and hwmod heading that way too, so
relying on the built-in kernel data won't work in the long run.

If we really wanted to, we could set some devices to disabled state
in the bootloader or in the kernel and rely on the SoC detection. But
then we're back to building all the data into the kernel. And we
won't be able to boot new SoC variants with just .dts changes in
the long run like device tree is supposed to do.

Regards,

Tony

  parent reply	other threads:[~2014-01-23 17:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52e06652.c103450a.79d7.6517@mx.google.com>
2014-01-23  1:35 ` next boot: 34 pass, 5 fail (next-20140122) Kevin Hilman
2014-01-23  6:23   ` Tero Kristo
2014-01-23  8:14     ` Florian Vaussard
2014-01-23  9:00       ` Tero Kristo
2014-01-23  9:15         ` Florian Vaussard
2014-01-23  9:41           ` Florian Vaussard
2014-01-23 12:27             ` Tero Kristo
2014-01-23 16:35               ` Florian Vaussard
2014-01-23 17:33                 ` Nishanth Menon
2014-01-24 20:37                   ` Florian Vaussard
2014-01-23 17:35                 ` Tony Lindgren [this message]
2014-01-24 18:00                   ` Tony Lindgren
2014-01-24 20:51                   ` Florian Vaussard
2014-01-24 18:11           ` Tony Lindgren
2014-01-24 18:13             ` Florian Vaussard
2014-02-05 15:23               ` Kevin Hilman
2014-02-06  8:47                 ` Florian Vaussard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123173500.GI7993@atomide.com \
    --to=tony@atomide.com \
    --cc=ash@gumstix.com \
    --cc=florian.vaussard@epfl.ch \
    --cc=kernel-build-reports@lists.linaro.org \
    --cc=khilman@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=olof@lixom.net \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).