From: Sebastian Reichel <sre@debian.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
freemangordon@abv.bg
Subject: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900
Date: Wed, 5 Feb 2014 17:31:17 +0100 [thread overview]
Message-ID: <20140205163117.GA15996@earth.universe> (raw)
In-Reply-To: <CAHYPw2Ep9VP6Tem979ewcztdxkHkG8eR_U31U=f5ibsVa5AS4Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi Pali,
On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali Rohár wrote:
> 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead #ifdef ?
This is the preferred kernel style as far as I know.
> 2) Why do you not write warning or info when omap type is not
> OMAP2_DEVICE_TYPE_SEC (e.g qemu) ?
I assumed, that the workaround is not needed for this device type.
I just added the warning for missing CONFIG_ARM_ERRATA_430973,
because its very likely a misconfigured kernel.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-02-05 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 12:33 [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900 Sebastian Reichel
2014-02-05 13:12 ` Pali Rohár
2014-02-05 16:31 ` Sebastian Reichel [this message]
2014-02-05 16:38 ` Pali Rohár
2014-02-05 17:17 ` Sebastian Reichel
2014-02-05 20:30 ` Ivaylo Dimitrov
2014-02-06 0:39 ` Sebastian Reichel
2014-02-05 20:42 ` Pali Rohár
2014-02-06 0:25 ` Sebastian Reichel
2014-02-16 23:04 ` Pavel Machek
2014-02-17 21:30 ` [PATCHv2] " Sebastian Reichel
2014-02-21 23:08 ` Tony Lindgren
2014-03-01 21:32 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205163117.GA15996@earth.universe \
--to=sre@debian.org \
--cc=freemangordon@abv.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox