From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
arm@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 23/62] ARM: omap1: fix building without 32K_TIMER
Date: Wed, 19 Mar 2014 13:34:31 -0700 [thread overview]
Message-ID: <20140319203431.GA8333@atomide.com> (raw)
In-Reply-To: <20140319200100.GB4271@saruman.home>
* Felipe Balbi <balbi@ti.com> [140319 13:06]:
> On Wed, Mar 19, 2014 at 02:59:13PM -0500, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Mar 19, 2014 at 08:29:20PM +0100, Arnd Bergmann wrote:
> > > If we enable CONFIG_OMAP_MPU_TIMER and CONFIG_OMAP_DM_TIMER but
> > > not CONFIG_OMAP_32K_TIMER on OMAP1, we currently get this build error:
> > >
> > > mach-omap1/pm.c: In function 'omap1_pm_idle':
> > > mach-omap1/pm.c:123:9: error: 'enable_dyn_sleep' undeclared (first use in this function)
> > > while (enable_dyn_sleep) {
> > > ^
> > > mach-omap1/pm.c:123:9: note: each undeclared identifier is reported only once for each function it appears in
> > >
> > > This attempts to fix the #ifdef logic to deal with all combinations
> > > of timers.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Cc: linux-omap@vger.kernel.org
> > > Cc: Tony Lindgren <tony@atomide.com>
> >
> > I had sent a fix for months and months ago, what happened to it ?
>
> Here
>
> http://marc.info/?l=linux-omap&m=138963632408031&w=2
>
> Tony, did you forget to send a pull request ?
Hmm yes weird, can't see it in my omap-for-v3.14/fixes branch.
I must have gotten interrupted while applying and then probably
ran git reset --hard before committing.
Arnd, maybe pick up Felipe's earlier patch instead?
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2014-03-19 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 19:28 [PATCH 00/62] arm-soc randconfig fixes Arnd Bergmann
2014-03-19 19:29 ` [PATCH 23/62] ARM: omap1: fix building without 32K_TIMER Arnd Bergmann
2014-03-19 19:59 ` Felipe Balbi
2014-03-19 20:01 ` Felipe Balbi
2014-03-19 20:34 ` Tony Lindgren [this message]
2014-03-21 16:01 ` Arnd Bergmann
2014-03-19 19:29 ` [PATCH 24/62] ARM: omap1: select I2C where needed for PMIC Arnd Bergmann
2014-03-19 20:46 ` Tony Lindgren
2014-03-19 20:57 ` Arnd Bergmann
2014-03-19 21:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319203431.GA8333@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).