From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/4] ARM: dts: Add support for OMAP4 Variscite OM44 family Date: Fri, 18 Apr 2014 08:57:22 -0700 Message-ID: <20140418155721.GC5354@atomide.com> References: <1397833849-22396-1-git-send-email-manabian@gmail.com> <1397833849-22396-2-git-send-email-manabian@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:38324 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752221AbaDRP53 (ORCPT ); Fri, 18 Apr 2014 11:57:29 -0400 Content-Disposition: inline In-Reply-To: <1397833849-22396-2-git-send-email-manabian@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Joachim Eastwood Cc: bcousson@baylibre.com, linux-arm-kernel@lists.infradead.org, tomi.valkeinen@ti.com, linux-omap@vger.kernel.org * Joachim Eastwood [140418 08:11]: > Add support for VAR-SOM-OM44[1] SODIMM system on module from Variscite. SoM > features a OMAP4460, 1GB RAM, Gigabit Ethernet (LAN7500) and optional WLAN/BT. > > Also add support for VAR-STK-OM44 development board from Variscite. This kit > features a VAR-SOM-OM44 and the carrier board VAR-OM44CustomBoard[2]. The > VAR-STK-OM44 is the same as VAR-DVK-OM44 but without the LCD display. > > omap4-var-stk-om44.dts replace the old and very limited omap4-var-som.dts. > > [1] http://www.variscite.com/products/system-on-module-som/cortex-a9/var-som-om44-cpu-ti-omap-4-omap4460 > [2] http://www.variscite.com/products/single-board-computers/var-om44customboard > > Signed-off-by: Joachim Eastwood > --- > .../devicetree/bindings/arm/omap/omap.txt | 3 + > .../devicetree/bindings/vendor-prefixes.txt | 1 + > arch/arm/boot/dts/Makefile | 2 +- > arch/arm/boot/dts/omap4-var-om44customboard.dtsi | 235 ++++++++++++++ > arch/arm/boot/dts/omap4-var-som-om44.dtsi | 343 +++++++++++++++++++++ > arch/arm/boot/dts/omap4-var-som.dts | 96 ------ > arch/arm/boot/dts/omap4-var-stk-om44.dts | 16 + > 7 files changed, 599 insertions(+), 97 deletions(-) > create mode 100644 arch/arm/boot/dts/omap4-var-om44customboard.dtsi > create mode 100644 arch/arm/boot/dts/omap4-var-som-om44.dtsi > delete mode 100644 arch/arm/boot/dts/omap4-var-som.dts > create mode 100644 arch/arm/boot/dts/omap4-var-stk-om44.dts Hmm don't you still need to keep omap4-var-som.dts to build just the core SoC module without any add-on boards? Also, you might want to use the OMAP4_CORE_IOPAD and OMAP4_WKUP_IOPAD macros in include/dt-bindings/pinctrl/omap.h to be able to check the registers against the TRM easier as you can use the physical register offset listed in the TRM. Regards, Tony