From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
Date: Fri, 18 Apr 2014 15:51:12 -0700 [thread overview]
Message-ID: <20140418225111.GP21823@atomide.com> (raw)
In-Reply-To: <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
* Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140415 08:46]:
> On Tue, Apr 15, 2014 at 10:35 AM, Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> wrote:
> > On 04/15/2014 10:12 AM, Robert Nelson wrote:
> >> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
> >>>
> >>> Signed-off-by: Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>> ---
> >>> arch/arm/boot/dts/Makefile | 1 +
> >>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
> >>> 2 files changed, 16 insertions(+)
> >>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>>
> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >>> index 35c146f..0bdeba3 100644
> >>> --- a/arch/arm/boot/dts/Makefile
> >>> +++ b/arch/arm/boot/dts/Makefile
> >>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
> >>> omap3-sbc-t3730.dtb \
> >>> omap3-devkit8000.dtb \
> >>> omap3-beagle-xm.dtb \
> >>> + omap3-beagle-xm-ab.dtb \
> >>> omap3-evm.dtb \
> >>> omap3-evm-37xx.dtb \
> >>> omap3-ldp.dtb \
> >>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>> new file mode 100644
> >>> index 0000000..9d81123
> >>> --- /dev/null
> >>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>> @@ -0,0 +1,15 @@
> >>> +/*
> >>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or modify
> >>> + * it under the terms of the GNU General Public License version 2 as
> >>> + * published by the Free Software Foundation.
> >>> + */
> >>> +
> >>> +#include "omap3-beagle-xm.dts"
> >>> +
> >>> +/ {
> >>> + /* HS USB Port 2 Power enable was inverted with the xM C */
> >>> + hsusb2_power: hsusb2_power_reg {
> >>> + enable-active-high;
> >> };
> >>> +};
> >>
> >> Crap, copy paste bug, there. I can send a v2, if you guys are happy
> >> with the "omap3-beagle-xm-ab.dtb" naming..
> >>
> >> Regards,
> >>
> > Will u-boot adequately handle this as part of find_fdt?
>
> It will after i submit something like: (this uses a new feature in v2014.04)
>
> https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
>
> Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found
> drop to old omap3-beagle-xm.dtb
>
> Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-18 22:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 15:09 [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B Robert Nelson
2014-04-15 15:12 ` Robert Nelson
2014-04-15 15:35 ` Nishanth Menon
2014-04-15 15:40 ` Robert Nelson
[not found] ` <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-18 22:51 ` Tony Lindgren [this message]
2014-04-18 23:42 ` Robert Nelson
2014-04-18 23:51 ` Tony Lindgren
2014-04-22 6:49 ` Gupta, Pekon
2014-04-22 14:03 ` Tony Lindgren
2014-04-24 22:34 ` Kevin Hilman
2014-04-24 22:32 ` Kevin Hilman
2014-04-24 23:21 ` Kevin Hilman
2014-04-24 23:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418225111.GP21823@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).