From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/2] Fix few omap gpmc regressions when booted with device tree Date: Tue, 22 Apr 2014 17:00:13 -0700 Message-ID: <20140423000012.GD12204@atomide.com> References: <1398128080-18903-1-git-send-email-tony@atomide.com> <20140422152347.GB19317@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:50905 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752460AbaDWAAU (ORCPT ); Tue, 22 Apr 2014 20:00:20 -0400 Content-Disposition: inline In-Reply-To: <20140422152347.GB19317@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Javier Martinez Canillas Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , Pekon Gupta , Dmitry Lifshitz * Tony Lindgren [140422 08:24]: > * Javier Martinez Canillas [140421 23:55]: > > On Tue, Apr 22, 2014 at 2:54 AM, Tony Lindgren wrote: > > > > > > 2. There seems to be some timing issues with smc911x where > > > rsync of larger files and apt-get dist-upgrade can produce > > > strange errors. This seems to work reliably when booted in > > > legacy mode. > > > > > > > In what board are you having this issue? The smsc911x driver supports > > both SMSC's LAN911x and LAN921x families and I see that we have two > > .dtsi files with different timings > > (arm/boot/dts/omap-gpmc-smsc{911x,9221}.dtsi). > > > > This is only a wild guess, but maybe your board has a smsc LAN921x > > chip but is including omap-gpmc-smsc911x.dtsi on its DTS? > > Yes it seems to have two LAN9220s, so this could be the reason. > I don't think we had the omap-gpmc-smsc9221.dtsi when I added the > timings initially. > > This is on a sbc-t3730 that I'm using as a gateway that was behaving > reliably before I upgraded it to DT based booting. It's currently > at v3.13-rc3 something, but I don't think we've much GPMC changes > since then. > > I'll try upgrading the kernel today and running some tests with > rsync. Looks like we can also remove quite a bit of duplicate > timing data by using omap-gpmc-smsc9221.dtsi, I'll try something > like the patch below. > > In any case, I suggest others run some tests on their GPMC Ethernet > too. > > +#include "omap-gpmc-smsc9221.dtsi" > + The 9221 timings won't work at all on 9220, it requires a 9221. I'll post a better clean-up patch to use the 911x timings. Upgraded the kernel and the occasional corruption is still there. I guess I need to test also the same kernel in legacy mode to try to narrow it down. Regards, Tony