* [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
@ 2014-04-15 15:09 Robert Nelson
2014-04-15 15:12 ` Robert Nelson
2014-04-24 22:32 ` Kevin Hilman
0 siblings, 2 replies; 13+ messages in thread
From: Robert Nelson @ 2014-04-15 15:09 UTC (permalink / raw)
To: bcousson, tony; +Cc: linux-omap, devicetree, linux-arm-kernel, Robert Nelson
BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
2 files changed, 16 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 35c146f..0bdeba3 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
omap3-sbc-t3730.dtb \
omap3-devkit8000.dtb \
omap3-beagle-xm.dtb \
+ omap3-beagle-xm-ab.dtb \
omap3-evm.dtb \
omap3-evm-37xx.dtb \
omap3-ldp.dtb \
diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
new file mode 100644
index 0000000..9d81123
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+ /* HS USB Port 2 Power enable was inverted with the xM C */
+ hsusb2_power: hsusb2_power_reg {
+ enable-active-high;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-15 15:09 [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B Robert Nelson
@ 2014-04-15 15:12 ` Robert Nelson
2014-04-15 15:35 ` Nishanth Menon
2014-04-24 22:32 ` Kevin Hilman
1 sibling, 1 reply; 13+ messages in thread
From: Robert Nelson @ 2014-04-15 15:12 UTC (permalink / raw)
To: Benoit Cousson, tony@atomide.com
Cc: linux-omap@vger.kernel.org, devicetree,
linux-arm-kernel@lists.infradead.org, Robert Nelson
On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson@gmail.com> wrote:
> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 35c146f..0bdeba3 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
> omap3-sbc-t3730.dtb \
> omap3-devkit8000.dtb \
> omap3-beagle-xm.dtb \
> + omap3-beagle-xm-ab.dtb \
> omap3-evm.dtb \
> omap3-evm-37xx.dtb \
> omap3-ldp.dtb \
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> new file mode 100644
> index 0000000..9d81123
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include "omap3-beagle-xm.dts"
> +
> +/ {
> + /* HS USB Port 2 Power enable was inverted with the xM C */
> + hsusb2_power: hsusb2_power_reg {
> + enable-active-high;
};
> +};
Crap, copy paste bug, there. I can send a v2, if you guys are happy
with the "omap3-beagle-xm-ab.dtb" naming..
Regards,
--
Robert Nelson
http://www.rcn-ee.com/
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-15 15:12 ` Robert Nelson
@ 2014-04-15 15:35 ` Nishanth Menon
2014-04-15 15:40 ` Robert Nelson
0 siblings, 1 reply; 13+ messages in thread
From: Nishanth Menon @ 2014-04-15 15:35 UTC (permalink / raw)
To: Robert Nelson, Benoit Cousson, tony@atomide.com
Cc: linux-omap@vger.kernel.org, devicetree,
linux-arm-kernel@lists.infradead.org
On 04/15/2014 10:12 AM, Robert Nelson wrote:
> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson@gmail.com> wrote:
>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>>
>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>> 2 files changed, 16 insertions(+)
>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 35c146f..0bdeba3 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>> omap3-sbc-t3730.dtb \
>> omap3-devkit8000.dtb \
>> omap3-beagle-xm.dtb \
>> + omap3-beagle-xm-ab.dtb \
>> omap3-evm.dtb \
>> omap3-evm-37xx.dtb \
>> omap3-ldp.dtb \
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> new file mode 100644
>> index 0000000..9d81123
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> @@ -0,0 +1,15 @@
>> +/*
>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include "omap3-beagle-xm.dts"
>> +
>> +/ {
>> + /* HS USB Port 2 Power enable was inverted with the xM C */
>> + hsusb2_power: hsusb2_power_reg {
>> + enable-active-high;
> };
>> +};
>
> Crap, copy paste bug, there. I can send a v2, if you guys are happy
> with the "omap3-beagle-xm-ab.dtb" naming..
>
> Regards,
>
Will u-boot adequately handle this as part of find_fdt?
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-15 15:35 ` Nishanth Menon
@ 2014-04-15 15:40 ` Robert Nelson
[not found] ` <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Robert Nelson @ 2014-04-15 15:40 UTC (permalink / raw)
To: Nishanth Menon
Cc: tony@atomide.com, devicetree, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Benoit Cousson
On Tue, Apr 15, 2014 at 10:35 AM, Nishanth Menon <nm@ti.com> wrote:
> On 04/15/2014 10:12 AM, Robert Nelson wrote:
>> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson@gmail.com> wrote:
>>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>>>
>>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>>> 2 files changed, 16 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 35c146f..0bdeba3 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>>> omap3-sbc-t3730.dtb \
>>> omap3-devkit8000.dtb \
>>> omap3-beagle-xm.dtb \
>>> + omap3-beagle-xm-ab.dtb \
>>> omap3-evm.dtb \
>>> omap3-evm-37xx.dtb \
>>> omap3-ldp.dtb \
>>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>> new file mode 100644
>>> index 0000000..9d81123
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>> @@ -0,0 +1,15 @@
>>> +/*
>>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> + */
>>> +
>>> +#include "omap3-beagle-xm.dts"
>>> +
>>> +/ {
>>> + /* HS USB Port 2 Power enable was inverted with the xM C */
>>> + hsusb2_power: hsusb2_power_reg {
>>> + enable-active-high;
>> };
>>> +};
>>
>> Crap, copy paste bug, there. I can send a v2, if you guys are happy
>> with the "omap3-beagle-xm-ab.dtb" naming..
>>
>> Regards,
>>
> Will u-boot adequately handle this as part of find_fdt?
It will after i submit something like: (this uses a new feature in v2014.04)
https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found
drop to old omap3-beagle-xm.dtb
Background: i also tried getting this having this fixed in u-boot:
>
> --
> Regards,
> Nishanth Menon
--
Robert Nelson
http://www.rcn-ee.com/
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
[not found] ` <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-04-18 22:51 ` Tony Lindgren
2014-04-18 23:42 ` Robert Nelson
0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2014-04-18 22:51 UTC (permalink / raw)
To: Robert Nelson
Cc: Nishanth Menon, devicetree,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Benoit Cousson
* Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140415 08:46]:
> On Tue, Apr 15, 2014 at 10:35 AM, Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> wrote:
> > On 04/15/2014 10:12 AM, Robert Nelson wrote:
> >> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
> >>>
> >>> Signed-off-by: Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>> ---
> >>> arch/arm/boot/dts/Makefile | 1 +
> >>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
> >>> 2 files changed, 16 insertions(+)
> >>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>>
> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >>> index 35c146f..0bdeba3 100644
> >>> --- a/arch/arm/boot/dts/Makefile
> >>> +++ b/arch/arm/boot/dts/Makefile
> >>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
> >>> omap3-sbc-t3730.dtb \
> >>> omap3-devkit8000.dtb \
> >>> omap3-beagle-xm.dtb \
> >>> + omap3-beagle-xm-ab.dtb \
> >>> omap3-evm.dtb \
> >>> omap3-evm-37xx.dtb \
> >>> omap3-ldp.dtb \
> >>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>> new file mode 100644
> >>> index 0000000..9d81123
> >>> --- /dev/null
> >>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>> @@ -0,0 +1,15 @@
> >>> +/*
> >>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or modify
> >>> + * it under the terms of the GNU General Public License version 2 as
> >>> + * published by the Free Software Foundation.
> >>> + */
> >>> +
> >>> +#include "omap3-beagle-xm.dts"
> >>> +
> >>> +/ {
> >>> + /* HS USB Port 2 Power enable was inverted with the xM C */
> >>> + hsusb2_power: hsusb2_power_reg {
> >>> + enable-active-high;
> >> };
> >>> +};
> >>
> >> Crap, copy paste bug, there. I can send a v2, if you guys are happy
> >> with the "omap3-beagle-xm-ab.dtb" naming..
> >>
> >> Regards,
> >>
> > Will u-boot adequately handle this as part of find_fdt?
>
> It will after i submit something like: (this uses a new feature in v2014.04)
>
> https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
>
> Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found
> drop to old omap3-beagle-xm.dtb
>
> Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-18 22:51 ` Tony Lindgren
@ 2014-04-18 23:42 ` Robert Nelson
2014-04-18 23:51 ` Tony Lindgren
0 siblings, 1 reply; 13+ messages in thread
From: Robert Nelson @ 2014-04-18 23:42 UTC (permalink / raw)
To: Tony Lindgren
Cc: Nishanth Menon, devicetree, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Benoit Cousson
On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Robert Nelson <robertcnelson@gmail.com> [140415 08:46]:
>> On Tue, Apr 15, 2014 at 10:35 AM, Nishanth Menon <nm@ti.com> wrote:
>> > On 04/15/2014 10:12 AM, Robert Nelson wrote:
>> >> On Tue, Apr 15, 2014 at 10:09 AM, Robert Nelson <robertcnelson@gmail.com> wrote:
>> >>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>> >>>
>> >>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
>> >>> ---
>> >>> arch/arm/boot/dts/Makefile | 1 +
>> >>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>> >>> 2 files changed, 16 insertions(+)
>> >>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>>
>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> >>> index 35c146f..0bdeba3 100644
>> >>> --- a/arch/arm/boot/dts/Makefile
>> >>> +++ b/arch/arm/boot/dts/Makefile
>> >>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>> >>> omap3-sbc-t3730.dtb \
>> >>> omap3-devkit8000.dtb \
>> >>> omap3-beagle-xm.dtb \
>> >>> + omap3-beagle-xm-ab.dtb \
>> >>> omap3-evm.dtb \
>> >>> omap3-evm-37xx.dtb \
>> >>> omap3-ldp.dtb \
>> >>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>> new file mode 100644
>> >>> index 0000000..9d81123
>> >>> --- /dev/null
>> >>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> >>> @@ -0,0 +1,15 @@
>> >>> +/*
>> >>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>> >>> + *
>> >>> + * This program is free software; you can redistribute it and/or modify
>> >>> + * it under the terms of the GNU General Public License version 2 as
>> >>> + * published by the Free Software Foundation.
>> >>> + */
>> >>> +
>> >>> +#include "omap3-beagle-xm.dts"
>> >>> +
>> >>> +/ {
>> >>> + /* HS USB Port 2 Power enable was inverted with the xM C */
>> >>> + hsusb2_power: hsusb2_power_reg {
>> >>> + enable-active-high;
>> >> };
>> >>> +};
>> >>
>> >> Crap, copy paste bug, there. I can send a v2, if you guys are happy
>> >> with the "omap3-beagle-xm-ab.dtb" naming..
>> >>
>> >> Regards,
>> >>
>> > Will u-boot adequately handle this as part of find_fdt?
>>
>> It will after i submit something like: (this uses a new feature in v2014.04)
>>
>> https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
>>
>> Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found
>> drop to old omap3-beagle-xm.dtb
>>
>> Background: i also tried getting this having this fixed in u-boot:
>
> Do we still need to apply this patch then?
Yeah, Tom want's it done in the kernel:
Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
Once this hits mainline, i'll submit a patch to u-boot to check for
the presence of this version and drop to the old dtb if not found.
Regards,
--
Robert Nelson
http://www.rcn-ee.com/
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-18 23:42 ` Robert Nelson
@ 2014-04-18 23:51 ` Tony Lindgren
2014-04-22 6:49 ` Gupta, Pekon
0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2014-04-18 23:51 UTC (permalink / raw)
To: Robert Nelson
Cc: Nishanth Menon, devicetree, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Benoit Cousson
* Robert Nelson <robertcnelson@gmail.com> [140418 16:42]:
> On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Robert Nelson <robertcnelson@gmail.com> [140415 08:46]:
> >>
> >> Background: i also tried getting this having this fixed in u-boot:
> >
> > Do we still need to apply this patch then?
>
> Yeah, Tom want's it done in the kernel:
>
> Here's my proposed u-boot patch:
> http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
>
> and Tom's recommendation:
> http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
>
> Once this hits mainline, i'll submit a patch to u-boot to check for
> the presence of this version and drop to the old dtb if not found.
OK applying into omap-for-v3.15/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-18 23:51 ` Tony Lindgren
@ 2014-04-22 6:49 ` Gupta, Pekon
2014-04-22 14:03 ` Tony Lindgren
0 siblings, 1 reply; 13+ messages in thread
From: Gupta, Pekon @ 2014-04-22 6:49 UTC (permalink / raw)
To: Tony Lindgren, Robert Nelson
Cc: Menon, Nishanth, devicetree, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Benoit Cousson
Tony,
>From: Tony Lindgren
>* Robert Nelson <robertcnelson@gmail.com> [140418 16:42]:
>> On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Robert Nelson <robertcnelson@gmail.com> [140415 08:46]:
>> >>
>> >> Background: i also tried getting this having this fixed in u-boot:
>> >
>> > Do we still need to apply this patch then?
>>
>> Yeah, Tom want's it done in the kernel:
>>
>> Here's my proposed u-boot patch:
>> http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
>>
>> and Tom's recommendation:
>> http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
>>
>> Once this hits mainline, i'll submit a patch to u-boot to check for
>> the presence of this version and drop to the old dtb if not found.
>
>OK applying into omap-for-v3.15/fixes thanks.
>
>Tony
You probably missed fixing below typo before applying this patch.
omap3-beagle-xm-ab.dts breaks without this.
> +/ {
> + /* HS USB Port 2 Power enable was inverted with the xM C */
> + hsusb2_power: hsusb2_power_reg {
> + enable-active-high;
};
> +};
with regards, pekon
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-22 6:49 ` Gupta, Pekon
@ 2014-04-22 14:03 ` Tony Lindgren
2014-04-24 22:34 ` Kevin Hilman
0 siblings, 1 reply; 13+ messages in thread
From: Tony Lindgren @ 2014-04-22 14:03 UTC (permalink / raw)
To: Gupta, Pekon
Cc: Robert Nelson, Menon, Nishanth, devicetree,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Benoit Cousson
* Gupta, Pekon <pekon@ti.com> [140421 23:49]:
> Tony,
>
> >From: Tony Lindgren
> >* Robert Nelson <robertcnelson@gmail.com> [140418 16:42]:
> >> On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@atomide.com> wrote:
> >> > * Robert Nelson <robertcnelson@gmail.com> [140415 08:46]:
> >> >>
> >> >> Background: i also tried getting this having this fixed in u-boot:
> >> >
> >> > Do we still need to apply this patch then?
> >>
> >> Yeah, Tom want's it done in the kernel:
> >>
> >> Here's my proposed u-boot patch:
> >> http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
> >>
> >> and Tom's recommendation:
> >> http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
> >>
> >> Once this hits mainline, i'll submit a patch to u-boot to check for
> >> the presence of this version and drop to the old dtb if not found.
> >
> >OK applying into omap-for-v3.15/fixes thanks.
> >
> >Tony
>
> You probably missed fixing below typo before applying this patch.
> omap3-beagle-xm-ab.dts breaks without this.
Yeah pushed out omap-for-v3.15/fixes-v2 with the missing bracket.
Regards,
Tony
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-15 15:09 [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B Robert Nelson
2014-04-15 15:12 ` Robert Nelson
@ 2014-04-24 22:32 ` Kevin Hilman
2014-04-24 23:21 ` Kevin Hilman
1 sibling, 1 reply; 13+ messages in thread
From: Kevin Hilman @ 2014-04-24 22:32 UTC (permalink / raw)
To: Robert Nelson; +Cc: bcousson, tony, linux-omap, devicetree, linux-arm-kernel
Robert Nelson <robertcnelson@gmail.com> writes:
> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 35c146f..0bdeba3 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
> omap3-sbc-t3730.dtb \
> omap3-devkit8000.dtb \
> omap3-beagle-xm.dtb \
> + omap3-beagle-xm-ab.dtb \
> omap3-evm.dtb \
> omap3-evm-37xx.dtb \
> omap3-ldp.dtb \
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> new file mode 100644
> index 0000000..9d81123
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include "omap3-beagle-xm.dts"
> +
> +/ {
> + /* HS USB Port 2 Power enable was inverted with the xM C */
> + hsusb2_power: hsusb2_power_reg {
> + enable-active-high;
Missing '};' here?
This causes build breakage in linux-omap master, which now has this
applied.
> +};
Kevin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-22 14:03 ` Tony Lindgren
@ 2014-04-24 22:34 ` Kevin Hilman
0 siblings, 0 replies; 13+ messages in thread
From: Kevin Hilman @ 2014-04-24 22:34 UTC (permalink / raw)
To: Tony Lindgren
Cc: Gupta, Pekon, Robert Nelson, Menon, Nishanth, devicetree,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Benoit Cousson
Tony Lindgren <tony@atomide.com> writes:
> * Gupta, Pekon <pekon@ti.com> [140421 23:49]:
>> Tony,
>>
>> >From: Tony Lindgren
>> >* Robert Nelson <robertcnelson@gmail.com> [140418 16:42]:
>> >> On Fri, Apr 18, 2014 at 5:51 PM, Tony Lindgren <tony@atomide.com> wrote:
>> >> > * Robert Nelson <robertcnelson@gmail.com> [140415 08:46]:
>> >> >>
>> >> >> Background: i also tried getting this having this fixed in u-boot:
>> >> >
>> >> > Do we still need to apply this patch then?
>> >>
>> >> Yeah, Tom want's it done in the kernel:
>> >>
>> >> Here's my proposed u-boot patch:
>> >> http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
>> >>
>> >> and Tom's recommendation:
>> >> http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
>> >>
>> >> Once this hits mainline, i'll submit a patch to u-boot to check for
>> >> the presence of this version and drop to the old dtb if not found.
>> >
>> >OK applying into omap-for-v3.15/fixes thanks.
>> >
>> >Tony
>>
>> You probably missed fixing below typo before applying this patch.
>> omap3-beagle-xm-ab.dts breaks without this.
>
> Yeah pushed out omap-for-v3.15/fixes-v2 with the missing bracket.
Your master branch still has the one that doesn't compile.
Kevin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-24 22:32 ` Kevin Hilman
@ 2014-04-24 23:21 ` Kevin Hilman
2014-04-24 23:37 ` Tony Lindgren
0 siblings, 1 reply; 13+ messages in thread
From: Kevin Hilman @ 2014-04-24 23:21 UTC (permalink / raw)
To: Robert Nelson
Cc: Benoit Cousson, Tony Lindgren, linux-omap,
devicetree@vger.kernel.org, linux-arm-kernel
On Thu, Apr 24, 2014 at 3:32 PM, Kevin Hilman <khilman@linaro.org> wrote:
> Robert Nelson <robertcnelson@gmail.com> writes:
>
>> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
>>
>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
>> 2 files changed, 16 insertions(+)
>> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 35c146f..0bdeba3 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>> omap3-sbc-t3730.dtb \
>> omap3-devkit8000.dtb \
>> omap3-beagle-xm.dtb \
>> + omap3-beagle-xm-ab.dtb \
>> omap3-evm.dtb \
>> omap3-evm-37xx.dtb \
>> omap3-ldp.dtb \
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> new file mode 100644
>> index 0000000..9d81123
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
>> @@ -0,0 +1,15 @@
>> +/*
>> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include "omap3-beagle-xm.dts"
>> +
>> +/ {
>> + /* HS USB Port 2 Power enable was inverted with the xM C */
>> + hsusb2_power: hsusb2_power_reg {
>> + enable-active-high;
>
> Missing '};' here?
>
> This causes build breakage in linux-omap master, which now has this
> applied.
ignore this. It's already been fixed, but was still lingering in
Tony's master branch.
Kevin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B
2014-04-24 23:21 ` Kevin Hilman
@ 2014-04-24 23:37 ` Tony Lindgren
0 siblings, 0 replies; 13+ messages in thread
From: Tony Lindgren @ 2014-04-24 23:37 UTC (permalink / raw)
To: Kevin Hilman
Cc: Robert Nelson, Benoit Cousson, linux-omap,
devicetree@vger.kernel.org, linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [140424 16:22]:
> On Thu, Apr 24, 2014 at 3:32 PM, Kevin Hilman <khilman@linaro.org> wrote:
> > Robert Nelson <robertcnelson@gmail.com> writes:
> >
> >> BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
> >>
> >> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> >> ---
> >> arch/arm/boot/dts/Makefile | 1 +
> >> arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
> >> 2 files changed, 16 insertions(+)
> >> create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index 35c146f..0bdeba3 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
> >> omap3-sbc-t3730.dtb \
> >> omap3-devkit8000.dtb \
> >> omap3-beagle-xm.dtb \
> >> + omap3-beagle-xm-ab.dtb \
> >> omap3-evm.dtb \
> >> omap3-evm-37xx.dtb \
> >> omap3-ldp.dtb \
> >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm-ab.dts b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >> new file mode 100644
> >> index 0000000..9d81123
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/omap3-beagle-xm-ab.dts
> >> @@ -0,0 +1,15 @@
> >> +/*
> >> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License version 2 as
> >> + * published by the Free Software Foundation.
> >> + */
> >> +
> >> +#include "omap3-beagle-xm.dts"
> >> +
> >> +/ {
> >> + /* HS USB Port 2 Power enable was inverted with the xM C */
> >> + hsusb2_power: hsusb2_power_reg {
> >> + enable-active-high;
> >
> > Missing '};' here?
> >
> > This causes build breakage in linux-omap master, which now has this
> > applied.
>
> ignore this. It's already been fixed, but was still lingering in
> Tony's master branch.
Oops, sorry yeah looks like I forgot to remerge the updated fixes
branch. Will update it today.
Tony
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-04-24 23:37 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-15 15:09 [PATCH] ARM: dts: Add support for the BeagleBoard xM A/B Robert Nelson
2014-04-15 15:12 ` Robert Nelson
2014-04-15 15:35 ` Nishanth Menon
2014-04-15 15:40 ` Robert Nelson
[not found] ` <CAOCHtYhygGFbUunY9abEkjKfpQ1hh-DfRfhm160NehSYhWJSRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-18 22:51 ` Tony Lindgren
2014-04-18 23:42 ` Robert Nelson
2014-04-18 23:51 ` Tony Lindgren
2014-04-22 6:49 ` Gupta, Pekon
2014-04-22 14:03 ` Tony Lindgren
2014-04-24 22:34 ` Kevin Hilman
2014-04-24 22:32 ` Kevin Hilman
2014-04-24 23:21 ` Kevin Hilman
2014-04-24 23:37 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).