public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jenny Tc <jenny.tc@intel.com>
Cc: linux-kernel@vger.kernel.org,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"Anton Vorontsov" <cbouatmailru@gmail.com>,
	"Anton Vorontsov" <anton.vorontsov@linaro.org>,
	"Kim Milo" <Milo.Kim@ti.com>, "Jingoo Han" <jg1.han@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Sachin Kamat" <sachin.kamat@linaro.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Rhyland Klein" <rklein@nvidia.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Sebastian Reichel" <sre@ring0.de>,
	aaro.koskinen@iki.fi,
	"Pallala Ramakrishna" <ramakrishna.pallala@intel.com>,
	freemangordon@abv.bg, linux-omap@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [RFC] power_supply: Introduce generic psy charging driver
Date: Mon, 28 Apr 2014 19:56:06 +0200	[thread overview]
Message-ID: <20140428175606.GA26042@amd.pavel.ucw.cz> (raw)
In-Reply-To: <20140428165436.GA23310@jenny-desktop>

On Mon 2014-04-28 22:24:36, Jenny Tc wrote:
> Dmitry/Pavel,
> 
> Request your feedback on this. Fixed the comments from Pavel and waiting for 
> your feedback on the changes

IIRC, my latest comments were "this is completely misdesigned, it is
using strings and table searches where it should use pointers". Did
that change?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2014-04-28 17:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07  4:10 [RFC] power_supply: Introduce generic psy charging driver Jenny TC
     [not found] ` <20140428165436.GA23310@jenny-desktop>
2014-04-28 17:56   ` Pavel Machek [this message]
2014-04-29  3:35     ` Jenny Tc
  -- strict thread matches above, loose matches on Subject: below --
2014-05-12 16:05 Jenny TC

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428175606.GA26042@amd.pavel.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=Milo.Kim@ti.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=anton.vorontsov@linaro.org \
    --cc=cbouatmailru@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=freemangordon@abv.bg \
    --cc=jenny.tc@intel.com \
    --cc=jg1.han@samsung.com \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pali.rohar@gmail.com \
    --cc=ramakrishna.pallala@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=rklein@nvidia.com \
    --cc=sachin.kamat@linaro.org \
    --cc=sre@ring0.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox