From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jenny Tc Subject: Re: [RFC] power_supply: Introduce generic psy charging driver Date: Tue, 29 Apr 2014 09:05:09 +0530 Message-ID: <20140429033509.GA24114@jenny-desktop> References: <1396843810-16743-1-git-send-email-jenny.tc@intel.com> <20140428165436.GA23310@jenny-desktop> <20140428175606.GA26042@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:3588 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbaD2DfR (ORCPT ); Mon, 28 Apr 2014 23:35:17 -0400 Content-Disposition: inline In-Reply-To: <20140428175606.GA26042@amd.pavel.ucw.cz> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Pavel Machek Cc: linux-kernel@vger.kernel.org, Dmitry Eremin-Solenikov , Anton Vorontsov , Anton Vorontsov , Kim Milo , Jingoo Han , Chanwoo Choi , Sachin Kamat , Lars-Peter Clausen , Pali =?iso-8859-1?Q?Roh=E1r?= , Rhyland Klein , "Rafael J. Wysocki" , David Woodhouse , Tony Lindgren , Russell King , Sebastian Reichel , aaro.koskinen@iki.fi, Pallala Ramakrishna , freemangordon@abv.bg, linux-omap@vger.kernel.org, Linus Walleij On Mon, Apr 28, 2014 at 07:56:06PM +0200, Pavel Machek wrote: > On Mon 2014-04-28 22:24:36, Jenny Tc wrote: > > Dmitry/Pavel, > > > > Request your feedback on this. Fixed the comments from Pavel and waiting for > > your feedback on the changes > > IIRC, my latest comments were "this is completely misdesigned, it is > using strings and table searches where it should use pointers". Did > that change? Yes, that's changed. > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html