From: Tony Lindgren <tony@atomide.com>
To: Pekon Gupta <pekon@ti.com>
Cc: bcousson@baylibre.com, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] ARM: dts: am335x-bone: add support for beaglebone NAND cape
Date: Tue, 6 May 2014 08:34:31 -0700 [thread overview]
Message-ID: <20140506153430.GD18474@atomide.com> (raw)
In-Reply-To: <1398152020-19391-2-git-send-email-pekon@ti.com>
* Pekon Gupta <pekon@ti.com> [140422 00:34]:
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -9,6 +9,7 @@
>
> #include "am33xx.dtsi"
> #include "am335x-bone-common.dtsi"
> +#include "am335x-bone-memory-cape.dts"
>
> &ldo3_reg {
> regulator-min-microvolt = <1800000>;
> --- a/arch/arm/boot/dts/am335x-boneblack.dts
> +++ b/arch/arm/boot/dts/am335x-boneblack.dts
> @@ -9,6 +9,7 @@
>
> #include "am33xx.dtsi"
> #include "am335x-bone-common.dtsi"
> +#include "am335x-bone-memory-cape.dts"
>
> &ldo3_reg {
> regulator-min-microvolt = <1800000>;
Have you checked that including the capes unconditionally for
non-integrated devices is safe? Maybe decompile the dtb using
dtc and see what is in the produced dts file?
I'm mostly worried about pinmux and GPMC as the pins can be used
by other capes and GPMC can have other devices.
Also, this should probably also wait until u-boot has been
confirmed of being able to enable these devices?
Regards,
Tony
next prev parent reply other threads:[~2014-05-06 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 7:33 [PATCH v3 0/4] add parallel NAND support for TI's new OMAPx and AMxx platforms (Part-2) Pekon Gupta
2014-04-22 7:33 ` [PATCH v3 1/4] ARM: dts: am335x-bone: add support for beaglebone NAND cape Pekon Gupta
2014-05-06 15:34 ` Tony Lindgren [this message]
2014-05-09 18:51 ` Gupta, Pekon
2014-05-12 16:46 ` Tony Lindgren
2014-04-22 7:33 ` [PATCH v3 2/4] ARM: dts: am437x-gp-evm: add support for parallel NAND flash Pekon Gupta
2014-05-06 15:39 ` Tony Lindgren
2014-05-07 19:19 ` Gupta, Pekon
2014-05-07 21:19 ` Tony Lindgren
2014-05-08 20:45 ` Tony Lindgren
2014-05-09 4:09 ` Gupta, Pekon
2014-05-06 10:41 ` [PATCH v3 0/4] add parallel NAND support for TI's new OMAPx and AMxx platforms (Part-2) Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506153430.GD18474@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).