From: Felipe Balbi <balbi@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Wolfram Sang' <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, 'Felipe Balbi' <balbi@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 07/16] i2c: omap: remove unnecessary OOM messages
Date: Tue, 6 May 2014 23:37:32 -0500 [thread overview]
Message-ID: <20140507043732.GA23766@saruman.home> (raw)
In-Reply-To: <018b01cf69ac$3922b120$ab681360$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Wed, May 07, 2014 at 01:24:23PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/i2c/busses/i2c-omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 85f8eac..b182793 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1114,10 +1114,8 @@ omap_i2c_probe(struct platform_device *pdev)
> }
>
> dev = devm_kzalloc(&pdev->dev, sizeof(struct omap_i2c_dev), GFP_KERNEL);
> - if (!dev) {
> - dev_err(&pdev->dev, "Menory allocation failed\n");
> + if (!dev)
> return -ENOMEM;
> - }
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> dev->base = devm_ioremap_resource(&pdev->dev, mem);
> --
> 1.7.10.4
>
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
parent reply other threads:[~2014-05-07 4:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <018b01cf69ac$3922b120$ab681360$%han@samsung.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507043732.GA23766@saruman.home \
--to=balbi@ti.com \
--cc=jg1.han@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).