From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 2/4] ARM: dts: am437x-gp-evm: add support for parallel NAND flash Date: Thu, 8 May 2014 13:45:46 -0700 Message-ID: <20140508204546.GD2198@atomide.com> References: <1398152020-19391-1-git-send-email-pekon@ti.com> <1398152020-19391-3-git-send-email-pekon@ti.com> <20140506153956.GE18474@atomide.com> <20980858CB6D3A4BAE95CA194937D5E73EACB432@DBDE04.ent.ti.com> <20140507211949.GA19102@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:38479 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323AbaEHUpv (ORCPT ); Thu, 8 May 2014 16:45:51 -0400 Content-Disposition: inline In-Reply-To: <20140507211949.GA19102@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Gupta, Pekon" Cc: "bcousson@baylibre.com" , linux-omap * Tony Lindgren [140507 14:20]: > * Gupta, Pekon [140507 12:20]: > > >From: Tony Lindgren [mailto:tony@atomide.com] > > >>* Pekon Gupta [140422 00:34]: > > >> +&gpmc { > > >> + status =3D "okay"; > > >> + pinctrl-names =3D "default"; > > >> + pinctrl-0 =3D <&nand_flash_x8>; > > >> + ranges =3D <0 0 0x08000000 0x10000000>; /* CS0: NAND */ > > > > > >Please use the minimum size 16MB GPMC range here, NAND only > > >has few registers addressable unlike NOR that actually uses the > > >whole range. > > > > > >> + nand@0,0 { > > >> + reg =3D <0 0 0>; /* CS0, offset 0 */ > > > > > >Then here map the true size of the NAND device IO register area. > > > > > >BTW, we should do the similar changes to other files so we can > > >unify the GPMC partitioning a bit. But that's unsafe to do until > > >we have fixed the issue of mapping GPMC devices to a different > > >location from the bootloader location. > > > > > I have found the fix of this issue in gpmc_cs_remap() just testing = it > > using beaglebone NOR cape. I'll post that separately, once I'm conf= ident. >=20 > OK that's great. Yet another issue I've noticed is that u-boot > seems to program 37xx L3 to run at 200 MHz and the LAN9220 > timings overflow the GPMC registers as 200 / 5 >=3D 32. And looks like we have a build warning in the -rc cycle with omap2plus_defconfig: drivers/mtd/nand/omap2.c:1250:12: warning: =E2=80=98erased_sector_bitfl= ips=E2=80=99 defined but not used [-Wunused-function] Can you please fix that if not already fixed? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html