From: Darren Etheridge <detheridge@ti.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-arm-kernel@lists.infradead.org,
"Wolfram Sang" <wsa@sang-engineering.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x-evm: fix comments for lcd pins
Date: Fri, 9 May 2014 12:38:20 -0500 [thread overview]
Message-ID: <20140509173820.GL2626@ti.com> (raw)
In-Reply-To: <20140509155929.GJ2626@ti.com>
Darren Etheridge <detheridge@ti.com> wrote on Fri [2014-May-09 10:59:30 -0500]:
> Wolfram,
>
> Wolfram Sang <wsa@the-dreams.de> wrote on Fri [2014-May-09 17:15:50 +0200]:
> > From: Wolfram Sang <wsa@sang-engineering.com>
> >
> > In the comments, LCD pins 16-23 were numbered in the wrong order.
> > Fix this and use proper pinmux constants for all entries while we are
> >
> Looks like you are absolutely correct - I just confirmed this from both
> the AM335x-EVM schematic and the AM335x pinmux utility.
>
> The same mistake is also in my EVMSK LCD enabling patch that is floating
> around on this list at the moment. I will fix that and resend it.
> BeagleBone Black only uses the first 16 LCD pins so the dts for that is
> correct.
>
> Thanks for finding and fixing it.
>
In the process of fixing up my EVMSK patch I applied this patch and tested it
on a 3.15-rc4 kernel running on an AM335x-EVM. Worked great - so your
pinmux constant conversion appears to be correct.
Tested-by: Darren Etheridge <detheridge@ti.com>
next prev parent reply other threads:[~2014-05-09 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 15:15 [PATCH] ARM: dts: am335x-evm: fix comments for lcd pins Wolfram Sang
2014-05-09 15:59 ` Darren Etheridge
2014-05-09 16:09 ` Wolfram Sang
2014-05-09 17:38 ` Darren Etheridge [this message]
2014-05-12 6:03 ` Uwe Kleine-König
2014-05-13 16:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509173820.GL2626@ti.com \
--to=detheridge@ti.com \
--cc=bcousson@baylibre.com \
--cc=bparrot@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).